Skip to content

Commit 1c1254f

Browse files
committed
mitm: error propagation in payload encrypt/decrypt and ssl_encapsulate()
1 parent e8e6198 commit 1c1254f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/mitm.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ impl Packet {
119119
) -> Result<()> {
120120
if (self.flags & ENCRYPTED) == ENCRYPTED {
121121
// save plain data for encryption
122-
let _ = server.ssl_write(&self.payload);
122+
server.ssl_write(&self.payload)?;
123123
// read encrypted data
124124
let mut res: Vec<u8> = Vec::new();
125-
let _ = mem_buf.read_to(&mut res);
125+
mem_buf.read_to(&mut res)?;
126126
self.payload = res;
127127
}
128128

@@ -137,10 +137,10 @@ impl Packet {
137137
) -> Result<()> {
138138
if (self.flags & ENCRYPTED) == ENCRYPTED {
139139
// save encrypted data
140-
let _ = mem_buf.write_from(&self.payload);
140+
mem_buf.write_from(&self.payload)?;
141141
// read plain data
142142
let mut res: Vec<u8> = Vec::new();
143-
let _ = server.read_to_end(&mut res);
143+
server.read_to_end(&mut res)?;
144144
self.payload = res;
145145
}
146146

@@ -394,7 +394,7 @@ pub async fn pkt_modify_hook(
394394
async fn ssl_encapsulate(mut mem_buf: SslMemBuf) -> Result<Packet> {
395395
// read SSL-generated data
396396
let mut res: Vec<u8> = Vec::new();
397-
let _ = mem_buf.read_to(&mut res);
397+
mem_buf.read_to(&mut res)?;
398398

399399
// create MESSAGE_ENCAPSULATED_SSL Packet
400400
let message_type = ControlMessageType::MESSAGE_ENCAPSULATED_SSL as u16;

0 commit comments

Comments
 (0)