2017 primality test performance improvement #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat, thanks for the speed up! (54 µs => 19 µs) You could go even further with wheel factorization but it's probably overkill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much for this repository. I learn a lot by working through problems and coming to your solutions when I'm stuck (which I must admit is often with AOC). This has been a gold mine for me.
While having a look at 2017 day 23 I noticed that the primality test could use some minor improvements to the performance, being only checking odd numbers (and 2), and using multiplication instead of finding the square root directly (though I'm not certain if the speed increase for that one is specific to my machine/architecture).
For me, these changes bring the benchmark results for part 2 from ~61μs down to ~25μs.