Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCDigestXXX functions are not public API for iOS #3

Open
SergejJurecko opened this issue Feb 4, 2019 · 4 comments
Open

CCDigestXXX functions are not public API for iOS #3

SergejJurecko opened this issue Feb 4, 2019 · 4 comments

Comments

@SergejJurecko
Copy link

Because this functions are used, this library can not be used in a published iOS app. App store rejects it for using private APIs.
@malept
Copy link
Owner

malept commented Feb 4, 2019

So this should be noted in the API docs, I guess. Would you like to create a pull request?

@SergejJurecko
Copy link
Author

I would prefer to switch to CC_XXX functions and limit pbkdf2 to macOS only. Would you be ok with that?

@malept
Copy link
Owner

malept commented Feb 4, 2019

That would also work. I would appreciate it if the docs mentioned this as well though.

@malept malept changed the title CCDigestXXX functions are not public API CCDigestXXX functions are not public API for iOS Feb 4, 2019
@malept
Copy link
Owner

malept commented Feb 4, 2019

Sorry, I think I misread. Are you proposing to change Hasher to use the CC_* instead? If so, I think that it would be better if there was a separate impl for iOS (see how crypto-hash is architected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malept @SergejJurecko