remove bevy_bindings as a whole and only use fine-grained features

Author: makspll

Cargo.toml

@@ -23,7 +23,6 @@ features = ["lua54", "rhai"]
 [features]
 default = [
     "core_functions",
-    "bevy_bindings",
     "bevy_core_bindings",
     "bevy_ecs_bindings",
     "bevy_hierarchy_bindings",
@@ -49,8 +48,6 @@ luau = ["bevy_mod_scripting_lua/luau", "lua"]
 
 # bindings 
 core_functions = ["bevy_mod_scripting_functions/core_functions"]
-bevy_bindings = ["bevy_mod_scripting_functions/bevy_bindings"]
-
 bevy_core_bindings = ["bevy_mod_scripting_functions/bevy_core"]
 bevy_ecs_bindings = ["bevy_mod_scripting_functions/bevy_ecs"]
 bevy_hierarchy_bindings = ["bevy_mod_scripting_functions/bevy_hierarchy"]

crates/bevy_mod_scripting_functions/Cargo.toml

@@ -12,17 +12,16 @@ categories = ["game-development"]
 readme = "readme.md"
 
 [features]
-bevy_core = ["bevy_bindings"]
-bevy_ecs = ["bevy_bindings"]
-bevy_hierarchy = ["bevy_bindings"]
-bevy_input = ["bevy_bindings"]
-bevy_math = ["bevy_bindings"]
-bevy_reflect = ["bevy_bindings"]
-bevy_time = ["bevy_bindings"]
-bevy_transform = ["bevy_bindings"]
+bevy_core = []
+bevy_ecs = []
+bevy_hierarchy = []
+bevy_input = []
+bevy_math = []
+bevy_reflect = []
+bevy_time = []
+bevy_transform = []
 
 core_functions = []
-bevy_bindings = []
 lua_bindings = ["bevy_mod_scripting_lua"]
 rhai_bindings = ["bevy_mod_scripting_rhai"]
 

crates/bevy_mod_scripting_functions/src/core.rs

@@ -32,25 +32,22 @@ use reflection_extensions::{PartialReflectExt, TypeIdExtensions};
 
 #[allow(unused_variables, reason = "feature flags")]
 pub fn register_bevy_bindings(app: &mut App) {
-    #[cfg(feature = "bevy_bindings")]
-    {
-        #[cfg(feature = "bevy_core")]
-        app.add_plugins(crate::bevy_bindings::bevy_core::BevyCoreScriptingPlugin);
-        #[cfg(feature = "bevy_ecs")]
-        app.add_plugins(crate::bevy_bindings::bevy_ecs::BevyEcsScriptingPlugin);
-        #[cfg(feature = "bevy_hierarchy")]
-        app.add_plugins(crate::bevy_bindings::bevy_hierarchy::BevyHierarchyScriptingPlugin);
-        #[cfg(feature = "bevy_input")]
-        app.add_plugins(crate::bevy_bindings::bevy_input::BevyInputScriptingPlugin);
-        #[cfg(feature = "bevy_math")]
-        app.add_plugins(crate::bevy_bindings::bevy_math::BevyMathScriptingPlugin);
-        #[cfg(feature = "bevy_reflect")]
-        app.add_plugins(crate::bevy_bindings::bevy_reflect::BevyReflectScriptingPlugin);
-        #[cfg(feature = "bevy_time")]
-        app.add_plugins(crate::bevy_bindings::bevy_time::BevyTimeScriptingPlugin);
-        #[cfg(feature = "bevy_transform")]
-        app.add_plugins(crate::bevy_bindings::bevy_transform::BevyTransformScriptingPlugin);
-    }
+    #[cfg(feature = "bevy_core")]
+    app.add_plugins(crate::bevy_bindings::bevy_core::BevyCoreScriptingPlugin);
+    #[cfg(feature = "bevy_ecs")]
+    app.add_plugins(crate::bevy_bindings::bevy_ecs::BevyEcsScriptingPlugin);
+    #[cfg(feature = "bevy_hierarchy")]
+    app.add_plugins(crate::bevy_bindings::bevy_hierarchy::BevyHierarchyScriptingPlugin);
+    #[cfg(feature = "bevy_input")]
+    app.add_plugins(crate::bevy_bindings::bevy_input::BevyInputScriptingPlugin);
+    #[cfg(feature = "bevy_math")]
+    app.add_plugins(crate::bevy_bindings::bevy_math::BevyMathScriptingPlugin);
+    #[cfg(feature = "bevy_reflect")]
+    app.add_plugins(crate::bevy_bindings::bevy_reflect::BevyReflectScriptingPlugin);
+    #[cfg(feature = "bevy_time")]
+    app.add_plugins(crate::bevy_bindings::bevy_time::BevyTimeScriptingPlugin);
+    #[cfg(feature = "bevy_transform")]
+    app.add_plugins(crate::bevy_bindings::bevy_transform::BevyTransformScriptingPlugin);
 }
 
 #[script_bindings(

crates/bevy_mod_scripting_functions/src/lib.rs

@@ -1,7 +1,6 @@
 #![allow(missing_docs)]
 
 use ::bevy::prelude::*;
-#[cfg(feature = "bevy_bindings")]
 pub mod bevy_bindings;
 pub mod core;
 pub use core::*;

crates/testing_crates/script_integration_test_harness/Cargo.toml

@@ -14,7 +14,6 @@ bevy = { workspace = true }
 test_utils = { workspace = true }
 bevy_mod_scripting_core = { workspace = true }
 bevy_mod_scripting_functions = { workspace = true, features = [
-    "bevy_bindings",
     "core_functions",
 ] }
 regex = { version = "1.11" }

docs/src/Summary/installation.md

@@ -50,7 +50,14 @@ By default all of the useful features are enabled, but you may disable them if y
 | Feature | Description |
 | ---- | ---- | 
 | core_functions | If enabled, will enable all core functions, i.e. bevy integrations which let you interact with Bevy via reflection |
-| bevy_bindings | If enabled, populates the function registry with additiona automatically generated bevy bindings. This includes functions on `glam` and `bevy::ecs` types. These are useful but will slow down compilation considerably. |
+| bevy_core_bindings | Enables bindings for the `bevy_core` module |
+| bevy_ecs_bindings | Enables bindings for the `bevy_ecs` module |
+| bevy_hierarchy_bindings | Enables bindings for the `bevy_hierarchy` module |
+| bevy_input_bindings | Enables bindings for the `bevy_input` module |
+| bevy_math_bindings | Enables bindings for the `bevy_math` module |
+| bevy_reflect_bindings | Enables bindings for the `bevy_reflect` module |
+| bevy_time_bindings | Enables bindings for the `bevy_time` module |
+| bevy_transform_bindings | Enables bindings for the `bevy_transform` module |
 | mlua_async | Enables `mlua/async`|
 | mlua_serialize | Enables `mlua/serialize` |
 | mlua_macros | Enables `mlua/macros` |