chore: fix compilation issue

Author: makspll

crates/bevy_mod_scripting_functions/src/core.rs

@@ -1,6 +1,6 @@
 //! Contains functions defined by the [`bevy_mod_scripting_core`] crate
 
-use std::collections::HashMap;
+use std::{collections::HashMap, ops::Deref};
 
 use bevy::prelude::*;
 use bevy_mod_scripting_core::{
@@ -789,7 +789,7 @@ impl ReflectReference {
         let functions = world
             .get_functions_on_type(type_id)
             .into_iter()
-            .map(|(_, v)| Val::new(v.info))
+            .map(|(_, v)| Val::new(v.info.deref().clone()))
             .collect::<Vec<_>>();
         // convert to info
         Ok(functions)

crates/ladfile_builder/src/lib.rs

@@ -319,16 +319,17 @@ impl<'t> LadFileBuilder<'t> {
     /// ```
     ///
     /// And then removes them from the original block, instead putting it in each argument / return docstring
-    pub fn add_function_info(&mut self, function_info: FunctionInfo) -> &mut Self {
+    pub fn add_function_info(&mut self, function_info: &FunctionInfo) -> &mut Self {
         let default_docstring = Cow::Owned("".into());
         let (main_docstring, arg_docstrings, return_docstring) =
             Self::split_docstring(function_info.docs.as_ref().unwrap_or(&default_docstring));
 
-        let function_id = self.lad_function_id_from_info(&function_info);
+        let function_id = self.lad_function_id_from_info(function_info);
         let lad_function = LadFunction {
-            identifier: function_info.name,
+            identifier: function_info.name.clone(),
             arguments: function_info
                 .arg_info
+                .clone()
                 .into_iter()
                 .map(|arg| {
                     let kind = match &arg.type_info {
@@ -351,6 +352,7 @@ impl<'t> LadFileBuilder<'t> {
                 kind: function_info
                     .return_info
                     .type_info
+                    .clone()
                     .map(|info| self.lad_type_kind_from_through_type(&info))
                     .unwrap_or_else(|| {
                         LadTypeKind::Unknown(
@@ -1080,9 +1082,9 @@ mod test {
         let mut lad_file = LadFileBuilder::new(&type_registry)
             .set_description("## Hello gentlemen\n I am  markdown file.\n - hello\n - world")
             .set_sorted(true)
-            .add_function_info(function_info)
-            .add_function_info(global_function_info)
-            .add_function_info(function_with_complex_args_info)
+            .add_function_info(&function_info)
+            .add_function_info(&global_function_info)
+            .add_function_info(&function_with_complex_args_info)
             .add_type::<StructType<usize>>()
             .add_type::<UnitType>()
             .add_type::<TupleStructType>()

crates/ladfile_builder/src/plugin.rs

@@ -96,7 +96,7 @@ pub fn generate_lad_file(
     );
 
     for (_, function) in function_registry.iter_namespace(World::into_namespace()) {
-        builder.add_function_info(function.info.clone());
+        builder.add_function_info(&function.info);
     }
 
     builder.set_insignificance(
@@ -131,13 +131,13 @@ pub fn generate_lad_file(
         for (_, function) in
             function_registry.iter_namespace(Namespace::OnType(type_info.type_id()))
         {
-            builder.add_function_info(function.info.clone());
+            builder.add_function_info(&function.info);
         }
     }
 
     // find functions on the global namespace
     for (_, function) in function_registry.iter_namespace(Namespace::Global) {
-        builder.add_function_info(function.info.clone());
+        builder.add_function_info(&function.info);
     }
 
     // find global instances

crates/languages/bevy_mod_scripting_rhai/src/lib.rs

@@ -122,8 +122,6 @@ impl Default for RhaiScriptingPlugin {
                             let name = key.name.clone();
                             if ReservedKeyword::is_reserved_keyword(&name) {
                                 let new_name = format!("{}_", name);
-                                let mut function = function.clone();
-                                function.info.name = new_name.clone().into();
                                 re_insertions.push((key.namespace, new_name, function.clone()));
                             }
                         }