fix digit clearing

masha256 · masha256 · commit 52ce395f42e3 · 2018-04-22T21:28:55.000-07:00
diff --git a/src/Neosegment.cpp b/src/Neosegment.cpp
@@ -20,7 +20,6 @@ void Neosegment::drawNumber(uint32_t n, uint32_t c) {
 void Neosegment::drawNumber(uint32_t n, uint16_t o, uint32_t c) {
 	String numStr = String(n, DEC);
 	uint16_t len = numStr.length();
-	clear();
 	for (uint16_t i = 0; i < len; i++) {
 		uint8_t digit = numStr.charAt(len-i-1) - '0';
 		drawDigit(digitMap[digit], o+(i*7), c);
@@ -31,6 +30,8 @@ void Neosegment::drawDigit(byte bits, uint16_t o, uint32_t c) {
 	for (uint8_t i = 7; i > 0; i--) {
 		if (bits & (1 << (i-1))) {
 			setPixelColor(o+7-i, c);
+		} else {
+			setPixelColor(o+7-i, 0);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ void Neosegment::drawNumber(uint32_t n, uint32_t c) {`
`20`	`20`	`void Neosegment::drawNumber(uint32_t n, uint16_t o, uint32_t c) {`
`21`	`21`	`String numStr = String(n, DEC);`
`22`	`22`	`uint16_t len = numStr.length();`
`23`		`- clear();`
`24`	`23`	`for (uint16_t i = 0; i < len; i++) {`
`25`	`24`	`uint8_t digit = numStr.charAt(len-i-1) - '0';`
`26`	`25`	`drawDigit(digitMap[digit], o+(i*7), c);`
`@@ -31,6 +30,8 @@ void Neosegment::drawDigit(byte bits, uint16_t o, uint32_t c) {`
`31`	`30`	`for (uint8_t i = 7; i > 0; i--) {`
`32`	`31`	`if (bits & (1 << (i-1))) {`
`33`	`32`	`setPixelColor(o+7-i, c);`
	`33`	`+ } else {`
	`34`	`+ setPixelColor(o+7-i, 0);`
`34`	`35`	`}`
`35`	`36`	`}`
`36`	`37`	`}`