Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete an individual message with wrong {message_id} deletes a message #131

Open
talolierwork opened this issue Jan 4, 2017 · 4 comments
Milestone

Comments

@talolierwork
Copy link

Using API V1: DELETE /api/v1/messages/{ message_id } with a wrong message id, e.g.
DELETE /api/v1/messages/aaa will still delete one message (very easy to reproduce).

Found in release 0.2.1.

-Tal.

@ian-kent
Copy link
Member

ian-kent commented Jan 9, 2017

Which storage backend are you using?

@talolierwork
Copy link
Author

I think it is mongo db, I did not know there is a way to use other storage engines.

@ian-kent
Copy link
Member

Without any configuration MailHog will use in-memory storage.

Can you confirm which storage backend it is - it'll say in the MailHog logs on startup. I've had a look at the MongoDB and in-memory backend code and there's no obvious bug, but narrowing it down a bit would help!

@ian-kent
Copy link
Member

I take that back - there is a bug in the in-memory storage which would cause exactly this!

@tyndyll tyndyll added this to the v1.1 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants