Skip to content

Magento Rest API exposing PII #39336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 5 tasks
shrinisadagopan opened this issue Nov 6, 2024 · 9 comments
Open
1 of 5 tasks

Magento Rest API exposing PII #39336

shrinisadagopan opened this issue Nov 6, 2024 · 9 comments
Assignees
Labels
Area: Framework Component: Framework/App Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Reported on 2.4.6-p8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@shrinisadagopan
Copy link

Preconditions and environment

Magento version - 2.4.6-P8
Environment - Local, Staging and Production

Steps to reproduce

My client is using Akamai Nonames to scan the application for PII in the incoming Rest API calls and if there (like cusotmer email address) Akamai is flagging it as security vulnerability and reporting it as a bug for the developers to fix it.

For example, the following Rest API is called by headless to Adobe Commerce where they are fetching the all the orders for the customers based on their email address to display it in the order history page...since the customer email address is exists in the query parameter Nonames system is flagging it as security vulnerability and report it as high risk.

/rest/V1/orders?searchCriteria[filterGroups][0][filters][0][conditionType]=eq&searchCriteria[filterGroups][0][filters][0][field]=customer_email&searchCriteria[filterGroups][0][filters][0][value][=[email protected]]

Expected result

Akamai Nonames scan should not find any PII information in the Rest API calls

Actual result

Akamai Nonames scan is finding the PII information in the Rest API calls and flagging it as security vulnerability.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Nov 6, 2024

Hi @shrinisadagopan. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 6, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.6-p8 Indicates original Magento version for the Issue report. label Nov 7, 2024
@engcom-Hotel engcom-Hotel self-assigned this Jan 8, 2025
Copy link

m2-assistant bot commented Jan 8, 2025

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Hotel
Copy link
Contributor

Hello @shrinisadagopan,

Thanks for the report and collaboration!

We are in discussion with the PO for this issue. Meanwhile, we are moving this issue On Hold. We will update you on this.

Thanks

@engcom-Hotel engcom-Hotel added Triage: Need PO Confirmation Requirements should be clarified/approved/confirmed with Product Manager. Not ready for fix/delivery Issue: On Hold and removed Issue: ready for confirmation labels Jan 8, 2025
@engcom-Hotel engcom-Hotel moved this from Ready for Confirmation to On Hold in Issue Confirmation and Triage Board Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 23, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to On Hold in Issue Confirmation and Triage Board Jan 23, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 28, 2025
@engcom-Hotel engcom-Hotel moved this from Ready for Confirmation to On Hold in Issue Confirmation and Triage Board Jan 28, 2025
@engcom-Hotel
Copy link
Contributor

Hello @shrinisadagopan,

We have received a reply from the PO, we are confirming this issue for further processing.

Thanks

@engcom-Hotel engcom-Hotel added Component: Framework/App Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Triage: Need PO Confirmation Requirements should be clarified/approved/confirmed with Product Manager. Not ready for fix/delivery Issue: On Hold labels Feb 11, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13904 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Feb 11, 2025

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@mapletechno
Copy link

@engcom-Hotel can I work on this fix? Thanks

@engcom-Hotel
Copy link
Contributor

Sure @mapletechno. Please refer to this #39521 (comment).

@mapletechno
Copy link

@magento I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Framework/App Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Reported on 2.4.6-p8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

5 participants