-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Open
Labels
Issue: ready for confirmationProgress: dev in progressProject: Platform HealthTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject itfeature request
Description
In PHP 8, new Union types feature was introduced.
(see details https://wiki.php.net/rfc/union_types_v2)
In the scope of this ticket, we need to add Union Types support for the places where we're using an information about parameter's class - for Tests:
- https://github.com/magento/magento2/blob/platform-health/dev/tests/static/testsuite/Magento/Test/Integrity/PublicCodeTest.php#L128
- https://github.com/magento/magento2/blob/platform-health/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/Injectable.php#L40
- https://github.com/magento/magento2/blob/platform-health/dev/tests/static/framework/Magento/CodeMessDetector/Rule/Design/CookieAndSessionMisuse.php
(better to re-check other possible places)
Expected result (*)
Magento should not break when union types are used. Tests should properly check all dependencies and so on.
Actual result (*)
Right now Magento can't handle union types introduced in php 8.
ihor-sviziev and candemiralp
Metadata
Metadata
Assignees
Labels
Issue: ready for confirmationProgress: dev in progressProject: Platform HealthTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject itfeature request
Type
Projects
Status
In Progress