Skip to content

Commit 4807653

Browse files
authored
Merge pull request #2376 from vitaliyboykocontributor/fixing-tests
Fixing tests
2 parents 1ff7368 + e2c6826 commit 4807653

File tree

3 files changed

+35
-24
lines changed

3 files changed

+35
-24
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
66

77
## 5.4.0
88

9+
## 5.3.1
10+
11+
### Fixed
12+
13+
- Custom theme couldn't be detected [#2348](https://github.com/magento/magento2-phpstorm-plugin/pull/2348)
14+
915
## 5.3.0
1016

1117
### Added

build.gradle

+28-23
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,28 @@
22
* Copyright © Magento, Inc. All rights reserved.
33
* See COPYING.txt for license details.
44
*/
5+
import org.jetbrains.intellij.platform.gradle.TestFrameworkType
56

67
plugins {
7-
id 'org.jetbrains.intellij' version '1.17.3'
8+
id "org.jetbrains.intellij.platform" version "2.1.0"
89
id 'checkstyle'
910
id 'pmd'
1011
id 'org.jetbrains.changelog' version '2.2.0'
1112
}
1213

1314
repositories {
1415
mavenCentral()
16+
17+
intellijPlatform {
18+
defaultRepositories()
19+
marketplace()
20+
}
1521
}
1622

1723
group 'com.magento.idea'
1824
version '5.4.0'
1925

20-
apply plugin: 'org.jetbrains.intellij'
26+
apply plugin: 'org.jetbrains.intellij.platform'
2127
apply plugin: 'java'
2228
apply plugin: 'idea'
2329
apply plugin: 'groovy'
@@ -32,28 +38,16 @@ java {
3238
targetCompatibility = javaVersion
3339
}
3440

35-
intellij {
41+
intellijPlatform {
3642
version = ideaVersion
37-
type = 'IU'
38-
pluginName = 'com.magento.idea.magento2plugin'
39-
plugins = [
40-
"com.jetbrains.php:$phpPluginVersion",
41-
'yaml',
42-
'java-i18n',
43-
'properties',
44-
'com.intellij.css',
45-
'JavaScript',
46-
'com.intellij.lang.jsgraphql:242.20224.155',
47-
'platform-images',
48-
'copyright'
49-
]
50-
updateSinceUntilBuild = false
51-
sameSinceUntilBuild = false
52-
downloadSources = !Boolean.valueOf(System.getenv('CI'))
53-
sandboxDir = "${project.rootDir}/.idea-sandbox"
54-
55-
patchPluginXml {
56-
changeNotes = provider { changelog.getLatest().toHTML() }
43+
projectName = 'com.magento.idea.magento2plugin'
44+
45+
pluginConfiguration {
46+
id = 'com.magento.idea.magento2plugin'
47+
name = 'Magento PhpStorm'
48+
version = '5.4.0'
49+
description = 'This is a PhpStorm IDE plugin for a better Magento 2 development workflow.'
50+
changeNotes = provider { changelog.getLatest().toHTML() } as Provider<? extends String>
5751
}
5852
}
5953

@@ -114,6 +108,17 @@ dependencies {
114108
testRuntimeOnly('org.junit.vintage:junit-vintage-engine:5.9.0')
115109
testRuntimeOnly("org.junit.platform:junit-platform-launcher:1.9.0")
116110
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.9.00")
111+
112+
intellijPlatform {
113+
intellijIdeaUltimate '2024.2.3'
114+
plugin("com.jetbrains.php", phpPluginVersion)
115+
plugin("com.intellij.lang.jsgraphql", "242.20224.155")
116+
bundledPlugin "JavaScript"
117+
instrumentationTools()
118+
bundledPlugin 'com.intellij.java'
119+
120+
testFramework TestFrameworkType.Platform.INSTANCE
121+
}
117122
}
118123

119124
test {

src/com/magento/idea/magento2plugin/util/RegExUtil.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public static class Magento {
6464
= "[A-Z][a-zA-Z0-9]+_[A-Z][a-zA-Z0-9]+";
6565

6666
public static final String THEME_NAME
67-
= "[a-z]+/[A-Z][a-zA-Z0-9_]+/[a-z][a-zA-Z0-9_]+";
67+
= "[a-z]+/[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+";
6868

6969
public static final String MFTF_CURLY_BRACES
7070
= ".*\\{\\{[^\\}]+\\}\\}.*";

0 commit comments

Comments
 (0)