Skip to content

Ignore HTML comments #482

@minsc78

Description

@minsc78

Preconditions

  1. Have a file test.html like this:
<!-- Comment <http://site.com/path/> -->

Steps to reproduce

  1. Run vendor/bin/phpcs -s --standard=Magento2 test.html

Expected result

  1. Show no errors.

Actual result

  1. Getting this output:
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 1 | ERROR | Avoid using self-closing tag with non-void html element - "<http://site.com/path/>
   |       |  (Magento2.Html.HtmlSelfClosingTags.HtmlSelfClosingNonVoidTag)
------------------------------------------------------------------------------------------------

Activity

m2-assistant

m2-assistant commented on Jul 13, 2024

@m2-assistant

Hi @minsc78. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

moved this to Ready for Grooming in Backlogon Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Ready for Grooming

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @minsc78

        Issue actions

          Ignore HTML comments · Issue #482 · magento/magento-coding-standard