Fix remaining phpcs issues

Author: loginesta

Magento2/Tests/Eslint/AbstractEslintTestCase.php

@@ -24,6 +24,7 @@ abstract class AbstractEslintTestCase extends TestCase
      */
     protected function assertFileContainsError(string $testFile, array $expectedMessages): void
     {
+        // phpcs:disable
         exec(
             'npm run eslint -- Magento2/Tests/Eslint/' . $testFile,
             $output

Magento2/Tests/Legacy/InstallUpgradeUnitTest.php

@@ -12,6 +12,9 @@
 
 class InstallUpgradeUnitTest extends AbstractSniffUnitTest
 {
+    /**
+     * @var string[]
+     */
     private $wrongFileNames = [
         'data-install-.inc',
         'data-upgrade-.inc',

Magento2/Tests/Legacy/_files/RestrictedCodeUnitTest/Magento/Framework/Model/ResourceModel/Iterator.php

@@ -1,11 +1,11 @@
 <?php
-
-use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
-
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+namespace Magento2\Tests\Legacy\_files\RestrictedCodeUnitTest\Magento\Framework\Model\ResourceModel;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
 
 /**
  * This is NOT actually a test, but a file that must be ignored by RestrictedCodeSniff
@@ -15,22 +15,22 @@
  */
 class IteratorDummyFile extends AbstractSniffUnitTest
 {
-    protected function shouldSkipTest()
+    protected function shouldSkipTest(): bool
     {
         return true;
     }
 
-    protected function getErrorList()
+    protected function getErrorList(): array
     {
         return [];
     }
 
-    protected function getWarningList()
+    protected function getWarningList(): array
     {
         return [];
     }
 
-    private function withProtectedClass()
+    private function withProtectedClass(): Zend_Db_Expr
     {
         return new \Zend_Db_Expr();
     }

Magento2/Tests/PHPCompatibility/Util/TestHelperPHPCompatibility.php

@@ -47,6 +47,7 @@ public function process(File $phpcsFile, $stackPtr)
     {
     }
 
+    /* phpcs:disable */
     /**
      * Wrapper to make the protected parent::isNumber() method testable.
      *
@@ -87,4 +88,5 @@ public function isNumericCalculation(File $phpcsFile, $start, $end)
     {
         return parent::isNumericCalculation($phpcsFile, $start, $end);
     }
+    /* phpcs:enable */
 }