Merge pull request #78 from magento-commerce/imported-svera-magento-coding-standard-290

[Imported] AC-669: Fixed directory name checking too lax

Author: svera

Diff for: Magento2/Sniffs/Legacy/InstallUpgradeSniff.php

@@ -64,7 +64,10 @@ public function process(File $phpcsFile, $stackPtr)
             }
         }
 
-        if (preg_match('/(sql|data)/', $fileInfo->getPath()) === 1) {
+        $folders = array_filter(explode('/', $fileInfo->getPath()));
+        $folderName = array_pop($folders);
+
+        if ($folderName === 'data' || $folderName === 'sql') {
             $phpcsFile->addError(
                 $fileInfo->getFilename()." is in an invalid directory ".$fileInfo->getPath().":\n"
                 . "- Create a data patch within module's Setup/Patch/Data folder for data upgrades.\n"

Diff for: Magento2/Tests/Legacy/_files/InstallUpgradeUnitTest/another-data-folder/file3.inc

@@ -0,0 +1 @@
+<?php

Diff for: Magento2/Tests/Legacy/_files/InstallUpgradeUnitTest/another-sql-folder/file4.inc

@@ -0,0 +1 @@
+<?php