Blackfire is enabled by default as it was before. Added option to disable it. Keeping switcher in PHP_EXTENSIONS env variable

Author: Igor Vitol

src/Command/BuildCompose.php

@@ -240,6 +240,11 @@ protected function configure(): void
             null,
             InputOption::VALUE_NONE,
             'Enables XDebug'
+        )->addOption(
+            Source\CliSource::OPTION_WITHOUT_BLACKFIRE,
+            null,
+            InputOption::VALUE_NONE,
+            'Do not load blackfire php extension by default'
         )->addOption(
             Source\CliSource::OPTION_ENV_VARIABLES,
             null,

src/Compose/Php/ExtensionResolver.php

@@ -47,6 +47,7 @@ class ExtensionResolver
         'sysvshm',
         'opcache',
         'zip',
+        'blackfire'
     ];
 
     /**
@@ -172,8 +173,7 @@ public static function getConfig(): array
 mkdir -p /tmp/blackfire
 tar zxpf /tmp/blackfire-probe.tar.gz -C /tmp/blackfire
 mv /tmp/blackfire/blackfire-*.so $(php -r "echo ini_get ('extension_dir');")/blackfire.so
-( echo extension=blackfire.so
-echo blackfire.agent_socket=tcp://blackfire:8707 ) > $(php -i | grep "additional .ini" | awk '{print $9}')/blackfire.ini
+echo blackfire.agent_socket=tcp://blackfire:8707 > $(php -i | grep "additional .ini" | awk '{print $9}')/blackfire.ini
 rm -rf /tmp/blackfire /tmp/blackfire-probe.tar.gz
 BASH
 // phpcs:enable

src/Config/Source/CliSource.php

@@ -52,6 +52,7 @@ class CliSource implements SourceInterface
     public const OPTION_NO_TMP_MOUNTS = 'no-tmp-mounts';
     public const OPTION_SYNC_ENGINE = 'sync-engine';
     public const OPTION_WITH_XDEBUG = 'with-xdebug';
+    public const OPTION_WITHOUT_BLACKFIRE = 'without-blackfire';
     public const OPTION_SET_DOCKER_HOST_XDEBUG = 'set-docker-host';
     public const OPTION_WITH_ENTRYPOINT = 'with-entrypoint';
     public const OPTION_WITH_MARIADB_CONF = 'with-mariadb-conf';
@@ -234,6 +235,12 @@ public function read(): Repository
             ]);
         }
 
+        if ($this->input->getOption(self::OPTION_WITHOUT_BLACKFIRE)) {
+            $repository->set([
+                self::PHP_DISABLED_EXTENSIONS => ['blackfire']
+            ]);
+        }
+
         if ($this->input->getOption(self::OPTION_SET_DOCKER_HOST_XDEBUG)) {
             $repository->set(self::SYSTEM_SET_DOCKER_HOST, true);
         }

src/Test/Integration/BuildComposeTest.php

@@ -87,6 +87,7 @@ public function buildDataProvider(): array
                     [CliSource::OPTION_WITH_TEST, true],
                     [CliSource::OPTION_WITH_CRON, true],
                     [CliSource::OPTION_WITH_XDEBUG, true],
+                    [CliSource::OPTION_WITHOUT_BLACKFIRE, true],
                     [CliSource::OPTION_ES, '5.2'],
                     [CliSource::OPTION_NO_ES, true],
                     [CliSource::OPTION_DB_INCREMENT_INCREMENT, 3],
@@ -104,6 +105,7 @@ public function buildDataProvider(): array
                     [CliSource::OPTION_WITH_TEST, true],
                     [CliSource::OPTION_WITH_CRON, true],
                     [CliSource::OPTION_WITH_XDEBUG, true],
+                    [CliSource::OPTION_WITHOUT_BLACKFIRE, true],
                     [CliSource::OPTION_ES, '5.2'],
                     [CliSource::OPTION_NO_ES, true],
                     [CliSource::OPTION_DB_INCREMENT_INCREMENT, 3],