MC-19259: Random failure of PAT builds on 2.3.3

adifucan · adifucan · commit 762e95bc99e5 · 2019-12-08T12:32:14.000-06:00
diff --git a/setup/src/Magento/Setup/Model/DataGenerator.php b/setup/src/Magento/Setup/Model/DataGenerator.php
@@ -72,7 +72,7 @@ public function generate($minAmountOfWords, $maxAmountOfWords, $key = null)
 
         if ($key === null || !array_key_exists($key, $this->generatedValues)) {
             for ($i = 0; $i < $numberOfWords; $i++) {
-                $result .= ' ' . $this->dictionaryData[mt_rand(0, count($this->dictionaryData) - 1)];
+                $result .= ' ' . $this->dictionaryData[random_int(0, count($this->dictionaryData) - 1)];
             }
             $result = trim($result);
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function generate($minAmountOfWords, $maxAmountOfWords, $key = null)`
`72`	`72`
`73`	`73`	`if ($key === null \|\| !array_key_exists($key, $this->generatedValues)) {`
`74`	`74`	`for ($i = 0; $i < $numberOfWords; $i++) {`
`75`		`- $result .= ' ' . $this->dictionaryData[mt_rand(0, count($this->dictionaryData) - 1)];`
	`75`	`+ $result .= ' ' . $this->dictionaryData[random_int(0, count($this->dictionaryData) - 1)];`
`76`	`76`	`}`
`77`	`77`	`$result = trim($result);`
`78`	`78`