Major Release 3 #237
Closed
maennchen
started this conversation in
Show and tell
Replies: 1 comment 8 replies
-
Hello @maennchen. It's great that you found the time to do a refactor 🎉 I finally was able to take the time to test this new release, and as far as I can tell, it seems to work fine! Basically, my diff looks like this: - $opt = new ArchiveOptions();
- // crucial option for a stream output
- $opt->setZeroHeader(true);
- return new ZipStream(null, $opt);
+ return new ZipStream(sendHttpHeaders:false); Using named arguments is a good idea. I suggest you go ahead and publish the final 3.0.0. Best, |
Beta Was this translation helpful? Give feedback.
8 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
EDIT: v3 has been released. If you face any issues, please open issues instead of commenting here.
🎉 We've just released the new major version 3 (beta).
News
Upgrade Instructions
https://github.com/maennchen/ZipStream-PHP/tree/3.0.0-beta.2#upgrade-to-version-300
Feedback
Plese try out the beta and let us know if you are facing issues / suggested improvements in the discussion.
Please be aware that this is a pre-release. Do not use it in production yet and the final release could still contain breaking changes based on the received feedback.
Beta Was this translation helpful? Give feedback.
All reactions