Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forking node-discord message causes clone crash #1

Open
5 tasks done
mmattice opened this issue Dec 11, 2019 · 1 comment
Open
5 tasks done

Forking node-discord message causes clone crash #1

mmattice opened this issue Dec 11, 2019 · 1 comment
Assignees
Labels
Future Improvement Issue will be fixed in future release good first issue Good for newcomers V3 Marked issue will be fixed (resolved) in version 3

Comments

@mmattice
Copy link

What are the steps to reproduce?

with [email protected]

Screen Shot 2019-12-10 at 9 34 16 PM

What happens?

Apparently taking the output of this discord message handler and forking it into two debugs gives this error. If I kill one of the links, I don't get the error.

11 Dec 05:30:57 - [red] Uncaught Exception:
11 Dec 05:30:57 - TypeError: Cannot assign to read only property 'writeQueueSize' of object '#<TCP>'
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:16)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
    at _clone (/usr/src/node-red/node_modules/clone/clone.js:162:18)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: `node $NODE_OPTIONS node_modules/node-red/red.js $FLOWS "--userDir" "/data"`
npm ERR! Exit status 1

What do you expect to happen?

I expect the message to be cloned without issue, or at least a non-fatal one.

Please tell us about your environment:

  • Node-RED version: 1.0.3
  • Node.js version: 10
  • npm version: 6.11.3
  • Platform/OS: docker nodered/node-red:1.0.3-10
  • Browser: Chrome
@madmax3365 madmax3365 self-assigned this Dec 17, 2019
@madmax3365
Copy link
Owner

madmax3365 commented Dec 17, 2019

Hi.
Thank you for your feedback, and sorry for the delay. As I can see error comes from node-red core clone function. I think the problem is that the discord node sends a too complex object to msg, so the clone fails. Going to check tomorrow :)
As a workaround, you can filter discord output with function node leaving only necessary properties until I'll have time to add property filtering functionality in the node.

@madmax3365 madmax3365 added bug Something isn't working good first issue Good for newcomers Future Improvement Issue will be fixed in future release and removed bug Something isn't working labels Dec 17, 2019
@madmax3365 madmax3365 added the V3 Marked issue will be fixed (resolved) in version 3 label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Improvement Issue will be fixed in future release good first issue Good for newcomers V3 Marked issue will be fixed (resolved) in version 3
Projects
None yet
Development

No branches or pull requests

2 participants