Skip to content

Commit d24b2d7

Browse files
committed
Revert "Changed overwrite confirmation to only appear on new notes"
This reverts commit 4695221.
1 parent 4695221 commit d24b2d7

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/main.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -512,15 +512,14 @@ export default class MediaDbPlugin extends Plugin {
512512
// look if file already exists and ask if it should be overwritten
513513
const file = this.app.vault.getAbstractFileByPath(filePath);
514514
if (file) {
515-
if (!options.isUpdating) {
516-
const shouldOverwrite = await new Promise<boolean>(resolve => {
517-
new ConfirmOverwriteModal(this.app, fileName, resolve).open();
518-
});
515+
const shouldOverwrite = await new Promise<boolean>(resolve => {
516+
new ConfirmOverwriteModal(this.app, fileName, resolve).open();
517+
});
519518

520-
if (!shouldOverwrite) {
521-
throw new Error('MDB | file creation cancelled by user');
522-
}
519+
if (!shouldOverwrite) {
520+
throw new Error('MDB | file creation cancelled by user');
523521
}
522+
524523
await this.app.vault.delete(file);
525524
}
526525

@@ -575,9 +574,9 @@ export default class MediaDbPlugin extends Plugin {
575574
console.debug(`MDB | newMediaTypeModel after merge`, newMediaTypeModel);
576575

577576
if (onlyMetadata) {
578-
await this.createMediaDbNoteFromModel(newMediaTypeModel, { attachFile: activeFile, folder: activeFile.parent ?? undefined, openNote: true, isUpdating: true });
577+
await this.createMediaDbNoteFromModel(newMediaTypeModel, { attachFile: activeFile, folder: activeFile.parent ?? undefined, openNote: true });
579578
} else {
580-
await this.createMediaDbNoteFromModel(newMediaTypeModel, { attachTemplate: true, folder: activeFile.parent ?? undefined, openNote: true, isUpdating: true });
579+
await this.createMediaDbNoteFromModel(newMediaTypeModel, { attachTemplate: true, folder: activeFile.parent ?? undefined, openNote: true });
581580
}
582581
}
583582

src/utils/Utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@ export interface CreateNoteOptions {
193193
attachFile?: TFile;
194194
openNote?: boolean;
195195
folder?: TFolder;
196-
isUpdating?: boolean; // New property
197196
}
198197

199198
export function migrateObject<T extends object>(object: T, oldData: any, defaultData: T): void {

0 commit comments

Comments
 (0)