Skip to content

M5EPD_Canvas::setDriver does not initialise correctly #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
murraypaul opened this issue Jan 29, 2021 · 1 comment
Closed

M5EPD_Canvas::setDriver does not initialise correctly #19

murraypaul opened this issue Jan 29, 2021 · 1 comment

Comments

@murraypaul
Copy link

murraypaul commented Jan 29, 2021 •
edited
Loading

M5EPD_Canvas::M5EPD_Canvas(M5EPD_Driver *driver) set _bpp to 4, overriding the default value of 16 from TFT_eSprite.

Neither M5EPD_Canvas::M5EPD_Canvas() nor M5EPD_Canvas::setDriver set _bpp.

(They also do not set _bytewidth, _last_push_x or _last_push_y, leaving them uninitialised.)

That means that

M5EPD_Canvas Canvas;
Canvas.setDriver(&M5.EPD);

Does not work in the same way that

M5EPD_Canvas Canvas(&M5.EPD);

Does.
murraypaul added a commit to murraypaul/M5EPD that referenced this issue Jan 29, 2021
@murraypaul
Issue m5stack#19. Display not initialised correct if using default co…
891bf9f 
…nstructor and setDriver()
@murraypaul
Copy link
Author

Pull request: #20

@icyqwq icyqwq closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murraypaul @icyqwq