Skip to content

Commit 8465fd8

Browse files
authored
Merge pull request showteeth#44 from m-jahn/dev
fix: example run time exceeded for 2 geoms
2 parents 9959cb7 + af333e4 commit 8465fd8

File tree

5 files changed

+18
-8
lines changed

5 files changed

+18
-8
lines changed

R/geom_cnv.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#' @export
2323
#'
2424
#' @examples
25-
#' if (requireNamespace("BSgenome.Hsapiens.UCSC.hg19", quietly = TRUE)) {
25+
#' \dontrun{
2626
#' library("BSgenome.Hsapiens.UCSC.hg19")
2727
#'
2828
#' # load track data

R/geom_gc.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#' @export
2121
#'
2222
#' @examples
23-
#' if (requireNamespace("BSgenome.Hsapiens.UCSC.hg19", quietly = TRUE)) {
23+
#' \dontrun{
2424
#' library("BSgenome.Hsapiens.UCSC.hg19")
2525
#'
2626
#' # load track data

cran-comments.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
11
# Resubmission
22

3-
Update for current submission: We have substantially removed the size of test
4-
files for the examples, reducing overall package size from ~30 Mb to only ~6 Mb.
5-
A further reduction was not possible as the package contains examples for
6-
many different NGS file types.
3+
Update for current submission:
4+
5+
- We have substantially removed the size of test files for the examples,
6+
reducing overall package size from ~30 Mb to only ~6 Mb. A further reduction
7+
was not possible as the package contains examples for many different NGS file
8+
types.
9+
10+
- Examples were reduced to run in shorter time or excluded from running at all.
11+
Please note that the 5 sec threshold feels very arbitrary and heavily depends
12+
on the test environment -- this package never exceeds the threshold when
13+
tested locally on a 3 year old average laptop, or in 3 different github actions
14+
workflows, but regularly fails on the CRAN server.
15+
16+
Background information:
717

818
This package has been submitted previously (2023, v0.7.1) and was removed from
919
CRAN due to several issues. In the mean time many functions were re-factored,

man/geom_cnv.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/geom_gc.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)