Simplify recording logic & fix bug with genius_url

README.md

@@ -125,12 +125,12 @@ the system at `${DEPLOYMENT_HOST}:${DOCKER_FRONTEND_PORT}`.
 - Skip banned tracks from album
 - Show albums/tracks collection with filters
   - Extract TrackLine component to reuse in collection
+  - Sort by cover colors (just for fun)
 - Descriptive error messages on frontend (e.g. for Genius API)
-- Add hint for clicking button on the last syllable when recoring (maybe even
-  color the last syllable of the last word of the line)
 - Add paging for albums & tracks
 - Put vocals track into "practice mode", mix with karaoke?
 - Add router to frontend (to support links like /album/123)
+- Show track name in page title
 - Download tracks' studio versions (ignore clip versions from YT Music)
 - Collection management: order of albums / stars / rating
 - Add editing text from frontend (to edit Genius parser's mistakes)

accompanist/celery/album.py

@@ -70,6 +70,7 @@ def process_album(search_query: str):
         vocals_path, instrumental_path, original_path = process_track(track["videoId"])
         track_name = track["title"]
         lyrics = None
+        genius_url = None
         try:
             lyrics, genius_url = get_lyrics_from_genius(artist.name, track_name)
         except Exception:

frontend/src/components/RecordTimecodesComponent.vue

@@ -36,13 +36,9 @@ const lyricsLines = props.lyricsText
   .filter((line) => line.trim() && !line.trim().startsWith("["));
 const lyricsWithTimecodes = reactive([]);
 let currentLineIndex = ref(0);
-let startTime = 0;
 
 const setupPlayer = () => {
   if (audioPlayer.value) {
-    audioPlayer.value.addEventListener("play", () => {
-      startTime = audioPlayer.value.currentTime;
-    });
     audioPlayer.value.play();
   }
 };
@@ -51,7 +47,7 @@ const recordTimecode = () => {
   const endTime = audioPlayer.value.currentTime;
   lyricsWithTimecodes.push({
     line: lyricsLines[currentLineIndex.value],
-    end_ts: endTime - startTime,
+    end_ts: endTime,
   });
   if (currentLineIndex.value == lyricsLines.length - 1) {
     emit("sendRecordedKaraokeLyrics", lyricsWithTimecodes);
@@ -62,7 +58,7 @@ const recordTimecode = () => {
 
 const recordInterludeEnd = () => {
   let interludeText = "[Проигрыш]";
-  let end_ts = audioPlayer.value.currentTime - startTime;
+  let end_ts = audioPlayer.value.currentTime;
   if (
     lyricsWithTimecodes[lyricsWithTimecodes.length - 1]?.line !== interludeText
   ) {