Skip to content

Conversation

@chrcuray
Copy link
Contributor

@chrcuray chrcuray commented Oct 3, 2025

Modify custom tab name behavior:
use available session name during session edit (was empty)
restoring to terminal title when custom name is empty (was not possible)

After comments on the #678 , the change was rewritten and the described use-case has been considered.

@tsujan
Copy link
Member

tsujan commented Nov 1, 2025

I found time to have a quick look (without testing it):

  • For whatever reason, the original code removes the tab icon only when the new text is set. Please keep that behavior in your PR.
  • Now that you're at it, please exclude the trailing and leading spaces from text. Particularly, we don't want a name like ; do we?

@chrcuray
Copy link
Contributor Author

chrcuray commented Nov 5, 2025

Hello Tsujan,
For the icon, I remove it at each tab text change. Because I do not know how to use/test icons, I am not sure it is what you suggested.
About spaces, I didn't only removed tailing and leading spaces with the "trimmed" method. I prefered to use "simplified" to also removed duplicated spaces.

Copy link
Member

@tsujan tsujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can't find any problem in it now. Let's give it to git users…

@tsujan tsujan merged commit ebd73b0 into lxqt:master Nov 7, 2025
@stefonarch stefonarch moved this to Improvements in Release 2.4 Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Improvements

Development

Successfully merging this pull request may close these issues.

2 participants