Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be able to specify different successful/failed ttl for each pod/job #62

Closed
dududko opened this issue Nov 23, 2020 · 2 comments
Closed

Comments

@dududko
Copy link

dududko commented Nov 23, 2020

Instead of using the global ttl configured in cleanup-operator, I would like to specify ttl more granual. Say, using the labels or annotations set ttl=1h on successful completion for job A, and specify ttl=10m for failed completion for job B.

I would like to do this using the labels kube-cleanup-operator/ttl-success: 1h and kube-cleanup-operator/ttl-fail: 10m.

Why is it important ?
For some releases it is very important to read and analyze logs before removing pods or jobs, but for other is it not so important. This is why in many cases you need to specify different ttl for each job, or use the default value from the cleanup-operator.

@lwolf
Copy link
Owner

lwolf commented Nov 24, 2020

Using annotations for this fine-tuning was the plan from the beginning, but nobody asked for it, so I kept it simple.
I'll look into the implications of adding it, when I have cycles to work on it.

Thanks

@lwolf
Copy link
Owner

lwolf commented Mar 28, 2021

closing this in favor of #72

@lwolf lwolf closed this as completed Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants