fix: some specs

Author: ronaldtse

lib/reqif/req_if_header.rb

@@ -1,10 +1,13 @@
-require "lutaml/model"
+# lib/reqif/req_if_header.rb
+require_relative "time_helper"
 
 module Reqif
   class ReqIfHeader < Lutaml::Model::Serializable
+    include TimeHelper
+
     attribute :identifier, :string
     attribute :comment, :string
-    attribute :creation_time, :time
+    attribute :creation_time, :string # Changed from :time to :string
     attribute :repository_id, :string
     attribute :req_if_tool_id, :string
     attribute :req_if_version, :string
@@ -24,5 +27,13 @@ class ReqIfHeader < Lutaml::Model::Serializable
       map_element "SOURCE-TOOL-ID", to: :source_tool_id
       map_element "TITLE", to: :title
     end
+
+    def creation_time=(time_str)
+      @creation_time = time_str
+    end
+
+    def creation_time
+      TimeHelper.parse_time(@creation_time)
+    end
   end
 end

lib/reqif/time_helper.rb

@@ -0,0 +1,12 @@
+require "time"
+
+module Reqif
+  module TimeHelper
+    def self.parse_time(time_str)
+      return nil if time_str.nil? || time_str.empty?
+      Time.parse(time_str)
+    rescue ArgumentError
+      nil
+    end
+  end
+end

reqif.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`
       .split("\x0")
-      .reject { |f| f.match(%r{^(test|spec|features)/}) }
+      .reject { |f| f.match(%r{^(test|features)/}) }
   end
   spec.bindir = "exe"
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }

spec/reqif/data_types_spec.rb

@@ -1,7 +1,8 @@
+# spec/reqif/data_types_spec.rb
 RSpec.describe Reqif::Datatypes do
   let(:datatypes_xml) do
     <<~XML
-      <DATATYPES>
+      <DATATYPES xmlns="http://www.omg.org/spec/ReqIF/20110401/reqif.xsd">
         <DATATYPE-DEFINITION-STRING IDENTIFIER="dt1" LAST-CHANGE="2023-10-26T12:00:00Z" LONG-NAME="String Type">
           <MAX-LENGTH>255</MAX-LENGTH>
         </DATATYPE-DEFINITION-STRING>
@@ -17,13 +18,15 @@
 
   describe "data type definitions" do
     it "parses string data type" do
-      string_type = datatypes.definition.find { |dt| dt.identifier == "dt1" }
+      string_type = datatypes.datatype_definition_string.first
+      expect(string_type.identifier).to eq("dt1")
       expect(string_type.long_name).to eq("String Type")
       expect(string_type.max_length).to eq(255)
     end
 
     it "parses integer data type" do
-      integer_type = datatypes.definition.find { |dt| dt.identifier == "dt2" }
+      integer_type = datatypes.datatype_definition_integer.first
+      expect(integer_type.identifier).to eq("dt2")
       expect(integer_type.long_name).to eq("Integer Type")
       expect(integer_type.max).to eq(100)
       expect(integer_type.min).to eq(0)

spec/reqif/doors_export_spec.rb

@@ -1,14 +1,19 @@
+# spec/reqif/doors_export_spec.rb
 RSpec.describe "IBM DOORS Export" do
   let(:xml_file) { File.read("spec/fixtures/doors_export.xml") }
   let(:reqif) { Reqif::ReqIf.from_xml(xml_file) }
 
   it "parses DOORS export correctly" do
-    expect(reqif.the_header.source_tool_id).to eq("IBM Rational DOORS Version 9.6.1")
+    expect(reqif.the_header.req_if_header.source_tool_id).to eq("IBM Rational DOORS Version 9.6.1")
 
-    datatypes = reqif.core_content.datatypes.definition
-    expect(datatypes.map(&:long_name)).to include("String", "Integer", "Real", "Date")
+    datatypes = reqif.core_content.req_if_content.datatypes
+    expect(datatypes.datatype_definition_string).to be_present
+    expect(datatypes.datatype_definition_integer).to be_present
+    expect(datatypes.datatype_definition_real).to be_present
+    expect(datatypes.datatype_definition_date).to be_present
 
-    spec_object = reqif.core_content.spec_objects.spec_object.first
-    expect(spec_object.values.first.the_value).to eq("System Requirements")
+    spec_object = reqif.core_content.req_if_content.spec_objects.spec_object.first
+    value = spec_object.values.attribute_value_string.first
+    expect(value.the_value).to eq("System Requirements")
   end
 end

spec/reqif/eclipse_export_spec.rb

@@ -1,16 +1,18 @@
+# spec/reqif/eclipse_export_spec.rb
 RSpec.describe "Eclipse RMF Export" do
   let(:xml_file) { File.read("spec/fixtures/eclipse_sample.xml") }
   let(:reqif) { Reqif::ReqIf.from_xml(xml_file) }
 
   it "parses Eclipse RMF export correctly" do
-    expect(reqif.the_header.req_if_tool_id).to eq("ProR (http://pror.org)")
-    expect(reqif.the_header.title).to eq("Requirements Document")
+    expect(reqif.the_header.req_if_header.req_if_tool_id).to eq("ProR (http://pror.org)")
+    expect(reqif.the_header.req_if_header.title).to eq("Requirements Document")
 
-    datatype = reqif.core_content.datatypes.definition.first
-    expect(datatype.long_name).to eq("T_String32k")
-    expect(datatype.max_length).to eq(32000)
+    datatypes = reqif.core_content.req_if_content.datatypes
+    string_type = datatypes.datatype_definition_string.first
+    expect(string_type.long_name).to eq("T_String32k")
+    expect(string_type.max_length).to eq(32000)
 
-    spec_type = reqif.core_content.spec_types.spec_object_type.first
+    spec_type = reqif.core_content.req_if_content.spec_types.spec_object_type.first
     expect(spec_type.long_name).to eq("Requirement Type")
   end
 end

spec/reqif/req_if_header_spec.rb

@@ -1,7 +1,8 @@
+# spec/reqif/req_if_header_spec.rb
 RSpec.describe Reqif::ReqIfHeader do
   let(:header_xml) do
     <<~XML
-      <REQ-IF-HEADER>
+      <REQ-IF-HEADER xmlns="http://www.omg.org/spec/ReqIF/20110401/reqif.xsd">
         <COMMENT>Example ReqIF file</COMMENT>
         <CREATION-TIME>2023-10-26T12:00:00Z</CREATION-TIME>
         <IDENTIFIER>_1234567890</IDENTIFIER>
@@ -18,7 +19,8 @@
   describe "attributes" do
     it "parses all header attributes" do
       expect(header.comment).to eq("Example ReqIF file")
-      expect(header.creation_time).to eq(DateTime.parse("2023-10-26T12:00:00Z"))
+      expect(header.creation_time).to be_a(Time)
+      expect(header.creation_time.utc.iso8601).to eq("2023-10-26T12:00:00Z")
       expect(header.identifier).to eq("_1234567890")
       expect(header.req_if_tool_id).to eq("reqif-tool")
       expect(header.req_if_version).to eq("1.0")