x509-cert: builder: don't require mutability of the signer

Signer (unlike SignerMut) is not expected to be mutable. Don't require
mutability of the Signer argument.

Signed-off-by: Dmitry Baryshkov <[email protected]>

Author: lumag

x509-cert/src/builder.rs

@@ -227,13 +227,13 @@ impl Profile {
 ///     validity,
 ///     subject,
 ///     pub_key,
-///     &mut signer,
+///     &signer,
 /// )
 /// .expect("Create certificate");
 /// ```
 pub struct CertificateBuilder<'s, S> {
     tbs: TbsCertificate,
-    signer: &'s mut S,
+    signer: &'s S,
 }
 
 impl<'s, S> CertificateBuilder<'s, S>
@@ -249,7 +249,7 @@ where
         mut validity: Validity,
         subject: Name,
         subject_public_key_info: SubjectPublicKeyInfoOwned,
-        signer: &'s mut S,
+        signer: &'s S,
     ) -> Result<Self>
     where
         S: Signer<Signature>,
@@ -315,7 +315,7 @@ where
     }
 
     /// Run the certificate through the signer and build the end certificate.
-    pub fn build<Signature>(&mut self) -> Result<Certificate>
+    pub fn build<Signature>(self) -> Result<Certificate>
     where
         S: Signer<Signature>,
         Signature: SignatureEncoding,
@@ -325,7 +325,7 @@ where
 
         let cert = Certificate {
             tbs_certificate: self.tbs.clone(),
-            signature_algorithm: self.tbs.signature.clone(),
+            signature_algorithm: self.tbs.signature,
             signature,
         };
 

x509-cert/tests/builder.rs

@@ -31,15 +31,15 @@ fn root_ca_certificate() {
     let pub_key =
         SubjectPublicKeyInfoOwned::try_from(RSA_2048_DER_EXAMPLE).expect("get rsa pub key");
 
-    let mut signer = rsa_signer();
-    let mut builder = CertificateBuilder::new(
+    let signer = rsa_signer();
+    let builder = CertificateBuilder::new(
         profile,
         Version::V3,
         serial_number,
         validity,
         subject,
         pub_key,
-        &mut signer,
+        &signer,
     )
     .expect("Create certificate");
 
@@ -75,15 +75,15 @@ fn sub_ca_certificate() {
     let pub_key =
         SubjectPublicKeyInfoOwned::try_from(RSA_2048_DER_EXAMPLE).expect("get rsa pub key");
 
-    let mut signer = ecdsa_signer();
-    let mut builder = CertificateBuilder::new::<ecdsa::Signature<NistP256>>(
+    let signer = ecdsa_signer();
+    let builder = CertificateBuilder::new::<ecdsa::Signature<NistP256>>(
         profile,
         Version::V3,
         serial_number,
         validity,
         subject,
         pub_key,
-        &mut signer,
+        &signer,
     )
     .expect("Create certificate");
 
@@ -126,15 +126,15 @@ fn leaf_certificate() {
     let pub_key =
         SubjectPublicKeyInfoOwned::try_from(RSA_2048_DER_EXAMPLE).expect("get rsa pub key");
 
-    let mut signer = ecdsa_signer();
-    let mut builder = CertificateBuilder::new::<ecdsa::Signature<NistP256>>(
+    let signer = ecdsa_signer();
+    let builder = CertificateBuilder::new::<ecdsa::Signature<NistP256>>(
         profile,
         Version::V3,
         serial_number,
         validity,
         subject,
         pub_key,
-        &mut signer,
+        &signer,
     )
     .expect("Create certificate");