Skip to content

Commit a5c70c6

Browse files
committed
fix(gateway-api) updates for brigade core 0.10.0
1 parent 873573f commit a5c70c6

File tree

10 files changed

+67
-336
lines changed

10 files changed

+67
-336
lines changed

.eslintrc.js

-286
This file was deleted.

Gopkg.lock

+6-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

+6
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,9 @@
2323

2424
[[constraint]]
2525
name = "gopkg.in/go-playground/webhooks.v3"
26+
version = "3.8.0"
27+
source = "https://github.com/go-playground/webhooks/tree/v3"
28+
29+
[[constraint]]
30+
name = "github.com/Azure/brigade"
31+
version = "0.10.0"

Makefile

-9
Original file line numberDiff line numberDiff line change
@@ -55,24 +55,15 @@ format:
5555
test -z "$$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -d {} + | tee /dev/stderr)" || \
5656
test -z "$$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -w {} + | tee /dev/stderr)"
5757

58-
HAS_NPM := $(shell command -v npm;)
59-
HAS_ESLINT := $(shell command -v eslint;)
6058
HAS_GOMETALINTER := $(shell command -v gometalinter;)
6159
HAS_DEP := $(shell command -v dep;)
6260
HAS_GIT := $(shell command -v git;)
63-
HAS_BINDATA := $(shell command -v go-bindata;)
6461

6562
.PHONY: bootstrap
6663
bootstrap:
67-
ifndef HAS_NPM
68-
$(error You must install npm)
69-
endif
7064
ifndef HAS_GIT
7165
$(error You must install git)
7266
endif
73-
ifndef HAS_ESLINT
74-
npm install -g eslint
75-
endif
7667
ifndef HAS_GOMETALINTER
7768
go get -u github.com/alecthomas/gometalinter
7869
gometalinter --install

README.md

+10-3
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@ $ git clone https://github.com/lukepatrick/brigade-gitlab-gateway
1919
$ cd brigade-gitlab-gateway
2020
```
2121
Helm install brigade-gitlab-gateway
22-
> note name and namespace (something important about brigade core)
22+
> note name and namespace can be customized.
2323
```bash
24-
$ helm install --name brigade-gl ./charts/brigade-gitlab-gateway
24+
$ helm install --name gl-gw ./charts/brigade-gitlab-gateway
2525
```
2626

2727
### From Repo
2828
Add this project as a helm repo
2929

3030
```bash
3131
$ helm repo add glgw https://lukepatrick.github.io/brigade-gitlab-gateway
32-
$ helm install -n brig-gl glgw/brigade-gitlab-gateway
32+
$ helm install -n gl-gw glgw/brigade-gitlab-gateway
3333
```
3434

3535
## Building from Source
@@ -45,6 +45,13 @@ To build a Docker image
4545
$ make docker-build
4646
```
4747

48+
## Compatibility
49+
50+
| GitLab Gateway | Brigade Core |
51+
|----------------|--------------|
52+
| v0.10.0 | v0.10.0 |
53+
| v0.1.0 | v0.9.0 (and previous)|
54+
4855
## GitLab Integration
4956
The Default URL for the GitLab Gateway is at `:7446/events/gitlab/`. In your GitLab project, go to Settings -> Integrations. Depending on how you set up
5057
your Kubernetes and the GitLab Gateway will determine your externally accessable host/IP/Port. Out of the box the gateway sets up as LoadBalancer; use the host/Cluster IP and check the GitLab Gateway Kubernetes Service for the external port (something like 30001).

0 commit comments

Comments
 (0)