Skip to content

Commit

Permalink
Tokenizer test (pytorch#8586)
Browse files Browse the repository at this point in the history
Summary:

X-link: pytorch-labs/tokenizers#21

Test Plan:
## OSS 
Build
```
cmake .     -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out
cmake --build cmake-out -j9 --target install
```

Test
```
(executorch) [[email protected] /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest
Test project /data/users/lfq/tokenizers/cmake-out
    Start 1: test_base64
1/5 Test pytorch-labs/tokenizers#1: test_base64 ......................   Passed    0.00 sec
    Start 2: test_llama2c_tokenizer
2/5 Test pytorch-labs/tokenizers#2: test_llama2c_tokenizer ...........   Passed    0.00 sec
    Start 3: test_pre_tokenizer
3/5 Test pytorch-labs/tokenizers#3: test_pre_tokenizer ...............   Passed    0.73 sec
    Start 4: test_sentencepiece
4/5 Test pytorch-labs/tokenizers#4: test_sentencepiece ...............   Passed    0.04 sec
    Start 5: test_tiktoken
5/5 Test pytorch-labs/tokenizers#5: test_tiktoken ....................   Passed    3.32 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   4.10 sec
```

## Internal
```
 buck2 test fbsource//xplat/pytorch/tokenizers/test:
 buck2 test fbcode//pytorch/tokenizers/test:
```

Reviewed By: larryliu0820

Differential Revision: D69860352

Pulled By: lucylq
  • Loading branch information
lucylq authored and facebook-github-bot committed Feb 19, 2025
1 parent 69ac165 commit 4e19077
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion shim/xplat/executorch/build/runtime_wrapper.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def _patch_kwargs_common(kwargs):
# don't pick up unexpected clients while things are still in flux.
if not kwargs.pop("_is_external_target", False):
for target in kwargs.get("visibility", []):
if not (target.startswith("//executorch") or target.startswith("@")):
if not (target.startswith("//executorch") or target.startswith("//pytorch/tokenizers") or target.startswith("@")):
fail("Please manage all external visibility using the " +
"EXECUTORCH_CLIENTS list in " +
"//executorch/build/fb/clients.bzl. " +
Expand Down
1 change: 1 addition & 0 deletions test/utils/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def define_common_targets():
],
visibility = [
"//executorch/...",
"//pytorch/tokenizers/...",
"@EXECUTORCH_CLIENTS",
],
deps = [
Expand Down

0 comments on commit 4e19077

Please sign in to comment.