Skip to content

Commit e2c105d

Browse files
authored
Merge pull request #92 from lucidsoftware/jjudd-progress-messages
Add progress_message to actions that currently do not have one
2 parents 8a5c93d + e8c0615 commit e2c105d

File tree

11 files changed

+20
-7
lines changed

11 files changed

+20
-7
lines changed

rules/private/phases/phase_binary_deployjar.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ def phase_binary_deployjar(ctx, g):
2222
),
2323
main_class = main_class,
2424
output = ctx.outputs.deploy_jar,
25-
progress_message = "scala deployable %s" % ctx.label,
25+
progress_message = "Creating Scala deploy jar %{label}",
2626
compression = True,
2727
)

rules/private/phases/phase_bootstrap_compile.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ def phase_bootstrap_compile(ctx, g):
124124
"supports-path-mapping": "1",
125125
},
126126
inputs = inputs,
127-
mnemonic = "BootstrapScalacompile",
127+
mnemonic = "BootstrapScalaCompile",
128+
progress_message = "Bootstrap Compiling Scala %{label}",
128129
outputs = [g.classpaths.jar, tmp],
129130
toolchain = "@rules_scala_annex//rules/scala:toolchain_type",
130131
tools = [ctx.executable._jar_creator],

rules/private/phases/phase_classpaths.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def phase_classpaths(ctx, g):
3939
ctx,
4040
inputs = deps,
4141
output = plugin_singlejar,
42-
progress_message = "singlejar scalac plugin %s" % plugin.label.name,
42+
progress_message = "Creating SingleJar for Scalac plugin %{label}",
4343
)
4444
actual_plugins.append(plugin_singlejar)
4545

rules/private/phases/phase_coverage_jacoco.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def phase_coverage_jacoco(ctx, g):
3939
},
4040
inputs = [in_out_pair[0] for in_out_pair in in_out_pairs],
4141
mnemonic = "JacocoInstrumenter",
42+
progress_message = "Analyzing Scala code coverage with JaCoCo %{label}",
4243
outputs = [in_out_pair[1] for in_out_pair in in_out_pairs],
4344
toolchain = "@rules_scala_annex//rules/scala:toolchain_type",
4445
)

rules/private/phases/phase_resources.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def phase_resources(ctx, g):
2323
ctx,
2424
inputs = [],
2525
output = resource_jar,
26-
progress_message = "singlejar resources %s" % ctx.label.name,
26+
progress_message = "Creating SingleJar for resources %{label}",
2727
resources = {
2828
_resources_make_path(file, ctx.attr.resource_strip_prefix): file
2929
for file in ctx.files.resources

rules/private/phases/phase_singlejar.bzl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,9 @@ def phase_singlejar(ctx, g):
2626
jar = getattr(v, "jar")
2727
inputs.append(jar)
2828

29-
_action_singlejar(ctx, inputs, ctx.outputs.jar)
29+
_action_singlejar(
30+
ctx,
31+
inputs = inputs,
32+
output = ctx.outputs.jar,
33+
progress_message = "Creating SingleJar %{label}",
34+
)

rules/private/phases/phase_zinc_compile.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ def phase_zinc_compile(ctx, g):
106106
inputs = inputs,
107107
mnemonic = "ScalaCompile",
108108
outputs = outputs,
109+
progress_message = "Compiling Scala %{label}",
109110
toolchain = "@rules_scala_annex//rules/scala:toolchain_type",
110111
)
111112

rules/private/phases/phase_zinc_depscheck.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ def phase_zinc_depscheck(ctx, g):
5252
},
5353
inputs = [g.compile.used],
5454
mnemonic = "ScalaCheckDeps",
55+
progress_message = "Checking Scala dependencies %{label}",
5556
outputs = [deps_check],
5657
toolchain = "@rules_scala_annex//rules/scala:toolchain_type",
5758
)

rules/scala/private/doc.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ def scaladoc_implementation(ctx):
6666
transitive = [classpath, compiler_classpath],
6767
),
6868
mnemonic = "ScalaDoc",
69+
progress_message = "Generating Scaladoc %{label}",
6970
outputs = [html, tmp],
7071
toolchain = None,
7172
)

rules/scala_proto/private/core.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def scala_proto_library_implementation(ctx):
5353
inputs = depset(direct = [], transitive = [transitive_sources]),
5454
mnemonic = "ScalaProtoCompile",
5555
outputs = [gendir],
56-
progress_message = "Compiling %{label} protobuf into Scala source",
56+
progress_message = "Compiling protobuf into Scala source %{label}",
5757
toolchain = "@rules_scala_annex//rules/scala_proto:compiler_toolchain_type",
5858
tools = [compiler.protoc],
5959
)
@@ -73,7 +73,7 @@ def scala_proto_library_implementation(ctx):
7373
inputs = [gendir],
7474
mnemonic = "SrcJar",
7575
outputs = [srcjar],
76-
progress_message = "Bundling compiled Scala into srcjar for %{label}",
76+
progress_message = "Bundling compiled Scala into srcjar %{label}",
7777
toolchain = None,
7878
tools = [ctx.executable._zipper],
7979
)

0 commit comments

Comments
 (0)