math.isnan, .isinf and .isfinite implementation #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements: - The modifications to the `math` library type definition - The new members of the `math` table - The new fastcalls - Conformance tests
vegorov-rbx
reviewed
Nov 6, 2025
vegorov-rbx
reviewed
Nov 6, 2025
vegorov-rbx
reviewed
Nov 6, 2025
vegorov-rbx
reviewed
Nov 6, 2025
vegorov-rbx
reviewed
Nov 6, 2025
Collaborator
vegorov-rbx
left a comment
vegorov-rbx
left a comment
There was a problem hiding this comment.
Builtin info is missing.
Compiler type info is missing as well.
vegorov-rbx
reviewed
Nov 6, 2025
Collaborator
|
Why is constant-folding skipped? |
Author
|
I didn't implement constant folding because I didn't think it would actually do anything in any real codebase, but I'm implementing it now (as well as fixing all these errors caused by me not running the conformance tests correctly yet again :,) ) |
Collaborator
|
We get requests for constant-folding more items even if it's hard to come up with realistic scenario (In this case, I can imagine some configuration constant having a special path for infinity(?)). |
Author
|
I think there are some missing compiler options that are causing mine to not emit the necessary warnings 😓 I checked the other fastcalls, hopefully I haven't missed any |
Author
|
Everything seems to be in order now, thank you |
vegorov-rbx
reviewed
Nov 6, 2025
Collaborator
|
Looking nice. Will be good to cover a bit more code. |
Adds constant folding tests Fixes `Types.cpp` `TypeMapVisitor` resolved type being wrong for the new functions
Author
|
I have added folding tests! |
Hello all! Another week, another release!
* Fixed `table.clone` in the old solver to ensure intersections of
tables were being entirely cloned: prior only the _first_ table in the
intersection would be copied:
```luau
type FIRST = { some: string }
type SECOND = FIRST & { thing: string }
local b: SECOND
-- c's type used to be FIRST, but should be the full type of SECOND
local c = table.clone(b)
```
* Fixed `table.clone` in the old solver to be more permissive and treat
a variadic return as having _at least_ one element. This works around
some unfortunate behavior in the old solver version of nonstrict mode,
see:
```luau
-- A.luau
--!nonstrict
return function()
return {}
end
-- B.luau
local A = require("A")
-- This line would previously error as `A` has type `() -> (...any)`, so
-- we might not be providing enough parameters to `table.clone`.
local _ = table.clone(A())
```
* Fixed a bug in the new solver where error suppression was not kicking
in for indexing, as in:
```luau
local function f(value: any)
if value ~= nil then
for k = 1, #value do
-- Previously this would error, claiming you cannot index into a `*error-type* | ~nil`
local _ = value[k]
end
end
end
```
* Fix the `getmetatable` type function in the new solver to accept
`*error-type*` and `table` as valid type inputs.
* Changed how error reporting for invalid `for ... in` loops works: for
now this may result in slightly worse error messages (see the example
below), but should mean error suppression is more consistent going
forward:
```luau
function my_iter(state: string, index: number)
return state, index
end
local my_state = {}
local first_index = "first"
-- Prior we would claim `my_state` and `first_index` are of the incorrect types,
-- now we claim that `my_iter` is of the incorrect type, which can be considered
-- true, but is less helpful.
for a, b in my_iter, my_state, first_index do
end
```
* Introduced `lua_rawgetptagged` and `lua_rawsetptagged`, as well as Lua
5.2+ compatibility macros `lua_rawgetp` and `lua_rawsetp`, to be able to
perform lookups into tables using tagged or untagged `lightuserdata`
without additional calls and stack manipulation. This enables a more
efficient lookup way for `lightuserdata` keys similar to how
`lua_rawgetfield` and `lua_rawgeti` avoid extra operations for their
corresponding types.
---
Co-authored-by: Andy Friesen <[email protected]>
Co-authored-by: Annie Tang <[email protected]>
Co-authored-by: Ariel Weiss <[email protected]>
Co-authored-by: Hunter Goldstein <[email protected]>
Co-authored-by: Varun Saini <[email protected]>
Co-authored-by: Vyacheslav Egorov <[email protected]>
---------
Co-authored-by: Varun Saini <[email protected]>
Co-authored-by: Alexander Youngblood <[email protected]>
Co-authored-by: Menarul Alam <[email protected]>
Co-authored-by: Aviral Goel <[email protected]>
Co-authored-by: Vighnesh <[email protected]>
Co-authored-by: Vyacheslav Egorov <[email protected]>
Co-authored-by: Ariel Weiss <[email protected]>
Co-authored-by: Andy Friesen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
mathlibrary type definitionmathtableLuauMathIsNanInfFinite,LuauCompileMathIsNanInfFinite,LuauTypeCheckerMathIsNanInfFinite, as per RFC https://rfcs.luau.org/math-isnan-isfinite-isinf.html
This PR does not implement NCG