💚 chore: default impl

Author: zeon256

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "lta_models"
 version = "0.6.0"
-authors = ["budinverse <[email protected]>"]
+authors = ["zeon256 <[email protected]>"]
 edition = "2021"
 license = "MIT"
 description = "🚍Models for lta-rs"

src/bus_enums.rs

@@ -37,7 +37,7 @@ pub enum Operator {
 /// DD -> Double Decker
 ///
 /// BD -> Bendy
-#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize)]
+#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize, Default)]
 #[serde(rename_all = "PascalCase")]
 pub enum BusType {
     #[serde(rename = "SD")]
@@ -49,22 +49,17 @@ pub enum BusType {
     #[serde(rename = "BD")]
     Bendy,
 
+    #[default]
     #[serde(other)]
     Unknown,
 }
 
-impl Default for BusType {
-    fn default() -> Self {
-        BusType::Unknown
-    }
-}
-
 /// SEA -> Seats available
 ///
 /// SDA -> Standing available
 ///
 /// LSD -> Limited standing
-#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize)]
+#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize, Default)]
 pub enum BusLoad {
     #[serde(rename = "SEA")]
     SeatsAvailable,
@@ -75,32 +70,24 @@ pub enum BusLoad {
     #[serde(rename = "LSD")]
     LimitedStanding,
 
+    #[default]
     #[serde(other)]
     Unknown,
 }
 
-impl Default for BusLoad {
-    fn default() -> Self {
-        BusLoad::Unknown
-    }
-}
 
-#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize)]
+#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize, Default)]
 pub enum BusFeature {
     #[serde(rename = "WAB")]
     WheelChairAccessible,
 
+    #[default]
     #[serde(other)]
     Unknown,
 }
 
-impl Default for BusFeature {
-    fn default() -> Self {
-        BusFeature::Unknown
-    }
-}
 
-#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize)]
+#[derive(Debug, Clone, PartialEq, PartialOrd, Deserialize, Serialize, Default)]
 pub enum BusCategory {
     #[serde(alias = "EXPRESS")]
     Express,
@@ -132,6 +119,7 @@ pub enum BusCategory {
     #[serde(alias = "FLAT FARE $2.00")]
     FlatFareTwoDollar,
 
+    #[default]
     #[serde(other)]
     Unknown,
 }

src/lib.rs

@@ -1,9 +1,11 @@
 //! Data Structures for lta-rs and for LTA datamall APIs
 
 // Forbid warnings in release builds:
+#![forbid(unsafe_code)]
 #![cfg_attr(not(debug_assertions), deny(warnings))]
 #![warn(
     clippy::all,
+    clippy::linkedlist,
     clippy::await_holding_lock,
     clippy::char_lit_as_u8,
     clippy::checked_conversions,
@@ -26,7 +28,6 @@
     clippy::invalid_upcast_comparisons,
     clippy::large_types_passed_by_value,
     clippy::let_unit_value,
-    clippy::linkedlist,
     clippy::lossy_float_literal,
     clippy::macro_use_imports,
     clippy::manual_ok_or,

src/utils.rs

@@ -234,7 +234,9 @@ pub mod de {
             write!(f, "StringWrapErr")
         }
     }
-
+    
+    /// # Errors
+    /// Fails when data cant be deserialized to String
     pub fn treat_error_as_none<'de, T, D>(deserializer: D) -> Result<Option<T>, D::Error>
     where
         T: Deserialize<'de>,