-
-
Notifications
You must be signed in to change notification settings - Fork 435
Open
Labels
Description
Description of the bug
Using bun, escpos-network behaves differently in the open method, specifically the error argument.
It is set to a Socket instance when using bun (1.1.45+196621f25), not using node (22.8.0)
I also opened a bug in bun.
Steps To Reproduce
I extracted the relevant code here and call both open (with a fix attempt) and open2 (current implementation in main). open2 fail with bun.
const net = require('net');
const EventEmitter = require('events');
const util = require('util');
function Network(address, port) {
EventEmitter.call(this);
this.address = address;
this.port = port || 9100;
this.device = new net.Socket();
return this;
}
util.inherits(Network, EventEmitter);
Network.prototype.open = function(callback) {
const self = this;
this.device.on('error', (err) => {
console.log('error', err);
callback && callback(err, self.device);
}).on('data', buf => {
// console.log('printer say:', buf);
}).connect(this.port, this.address, function(err) {
if (err && err instanceof Error) {
console.log('connect error', err);
callback && callback(err, self.device);
return;
}
self.emit('connect', self.device);
callback && callback(null, self.device);
});
return this;
};
Network.prototype.open2 = function(callback){
var self = this;
this.device.on("error", (err) => {
callback && callback(err, self.device);
}).on('data', buf => {
// console.log('printer say:', buf);
}).connect(this.port, this.address, function(err){
self.emit('connect', self.device);
callback && callback(err, self.device);
});
return this;
};
// Usage example
let device = new Network('192.168.1.100', 9100);
device.open(function(error, device) {
if (error) {
console.log('Connection error open');
return;
}
console.log('Connected to device open');
device.end();
});
device = new Network('192.168.1.100', 9100);
device.open2(function(error, device) {
if (error) {
console.log('Connection error open2:');
return;
}
console.log('Connected to device open2');
device.end();
});
Additional Information
No response