[project @ Do not send openid.ns values in OpenID 1 messages]

Author: tailor

Auth/OpenID/Message.php

@@ -589,6 +589,7 @@ function toPostArgs()
         // Add namespace definitions to the output
         foreach ($this->namespaces->iteritems() as $pair) {
             list($ns_uri, $alias) = $pair;
+
             if ($alias == Auth_OpenID_NULL_NAMESPACE) {
                 if ($ns_uri != Auth_OpenID_OPENID1_NS) {
                     $args['openid.ns'] = $ns_uri;
@@ -602,8 +603,10 @@ function toPostArgs()
                     // could look in the signed list.
                 }
             } else {
-                $ns_key = 'openid.ns.' . $alias;
-                $args[$ns_key] = $ns_uri;
+                if ($this->getOpenIDNamespace() != Auth_OpenID_OPENID1_NS) {
+                    $ns_key = 'openid.ns.' . $alias;
+                    $args[$ns_key] = $ns_uri;
+                }
             }
         }
 

Tests/Auth/OpenID/AuthRequest.php

@@ -114,7 +114,6 @@ function test_addExtensionArg()
         // namespaces. Really it doesn't care that it has alias "0",
         // but that is tested anyway
         $post_args = $msg->toPostArgs();
-        $this->assertEquals('bag:', $post_args['openid.ns.ext0']);
         $this->assertEquals('brown', $post_args['openid.ext0.color']);
         $this->assertEquals('paper', $post_args['openid.ext0.material']);
     }