[pentest] Use general cryptolib target #28825
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siemen11
added
the
CherryPick:earlgrey_1.0.0
siemen11
force-pushed
the
pentest_deps
branch
from
3f96333 to
3600951
Compare
siemen11
force-pushed
the
pentest_deps
branch
from
3600951 to
8dd91af
Compare
Move the header files from keyblob and integrity to include. These functions and constants are needed for the use of the crypto library. Signed-off-by: Siemen Dhooghe <[email protected]>
siemen11
force-pushed
the
pentest_deps
branch
3 times, most recently
from
4d0e1dd to
d98cbff
Compare
Use the crypto target as a dependency for the pentest framework instead of the separate targets. Signed-off-by: Siemen Dhooghe <[email protected]>
siemen11
force-pushed
the
pentest_deps
branch
2 times, most recently
from
8ba2f7e to
4280da6
Compare
nasahlpa
reviewed
Nov 26, 2025
sw/device/lib/crypto/include/p384.h
Outdated
|
|
||
| #ifndef OPENTITAN_SW_DEVICE_LIB_CRYPTO_IMPL_ECC_P384_H_ | ||
| #define OPENTITAN_SW_DEVICE_LIB_CRYPTO_IMPL_ECC_P384_H_ | ||
| #ifndef OPENTITAN_SW_DEVICE_LIB_CRYPTO_INCLUDE_P384_H_ |
Member
There was a problem hiding this comment.
Hi Siemen
I don't think that we simply should move the header files from the internal impl folder to the public API include folder. The reason is that we would now expose internal functions (such as p384_ecdsa_sign_start) which the user should not use by themselves.
I believe a better option would be to move functions that the user needs to use to the include folder and keep the ones the user should not use in the impl folder.
siemen11
force-pushed
the
pentest_deps
branch
from
4280da6 to
e3995e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the crypto target as a dependency for the pentest framework instead of the separate targets.