Backport #26007 ([rom_ext] Update the ROM_EXT minor version) #28797
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the ROM_EXT minor version to `102`. I'm using the offset 100 as a starting point to distinguish A1 development ROM_EXTs from ES development ROM_EXTs. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 3667195)
jwnrt
approved these changes
Nov 21, 2025
cfrantz
approved these changes
Dec 1, 2025
Contributor
I don't think we have anything that specifically depends on these version numbers, but I don't have a problem merging these over. At some point, I'd like to move to encoding the date into the minor version rather than an arbitrary number (You can fit a 10 digit number into a 32-bit integer, so one can encode something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26007 ([rom_ext] Update the ROM_EXT minor version). It is not entirely clear of backporting the minor version change is meaningful or not for master but since some tests or tooling might later depend on reading this version, I think it's safer to backport this.