[cryptolib] Move p256 and p384 headers to include

The p256 and p384 header files are needed to easily create variables for
the input of ecc functions. Move those to public.

Signed-off-by: Siemen Dhooghe <[email protected]>

Author: siemen11

sw/device/lib/crypto/impl/ecc/BUILD

@@ -9,7 +9,7 @@ load("//rules/opentitan:defs.bzl", "OPENTITAN_CPU")
 cc_library(
     name = "p256",
     srcs = ["p256.c"],
-    hdrs = ["p256.h"],
+    hdrs = ["//sw/device/lib/crypto/include:p256.h"],
     target_compatible_with = [OPENTITAN_CPU],
     deps = [
         "//sw/device/lib/base:crc32",
@@ -25,7 +25,7 @@ cc_library(
 cc_library(
     name = "p384",
     srcs = ["p384.c"],
-    hdrs = ["p384.h"],
+    hdrs = ["//sw/device/lib/crypto/include:p384.h"],
     target_compatible_with = [OPENTITAN_CPU],
     deps = [
         "//sw/device/lib/base:crc32",

sw/device/lib/crypto/impl/ecc/p256.c

@@ -2,7 +2,7 @@
 // Licensed under the Apache License, Version 2.0, see LICENSE for details.
 // SPDX-License-Identifier: Apache-2.0
 
-#include "sw/device/lib/crypto/impl/ecc/p256.h"
+#include "sw/device/lib/crypto/include/p256.h"
 
 #include "sw/device/lib/base/crc32.h"
 #include "sw/device/lib/base/hardened.h"

sw/device/lib/crypto/impl/ecc/p384.c

@@ -2,7 +2,7 @@
 // Licensed under the Apache License, Version 2.0, see LICENSE for details.
 // SPDX-License-Identifier: Apache-2.0
 
-#include "sw/device/lib/crypto/impl/ecc/p384.h"
+#include "sw/device/lib/crypto/include/p384.h"
 
 #include "sw/device/lib/base/crc32.h"
 #include "sw/device/lib/base/hardened.h"

sw/device/lib/crypto/impl/ecc_p256.c

@@ -7,11 +7,11 @@
 #include "sw/device/lib/base/hardened_memory.h"
 #include "sw/device/lib/crypto/drivers/entropy.h"
 #include "sw/device/lib/crypto/drivers/hmac.h"
-#include "sw/device/lib/crypto/impl/ecc/p256.h"
 #include "sw/device/lib/crypto/impl/security_config.h"
 #include "sw/device/lib/crypto/include/datatypes.h"
 #include "sw/device/lib/crypto/include/integrity.h"
 #include "sw/device/lib/crypto/include/keyblob.h"
+#include "sw/device/lib/crypto/include/p256.h"
 
 // Module ID for status codes.
 #define MODULE_ID MAKE_MODULE_ID('p', '2', '5')

sw/device/lib/crypto/impl/ecc_p384.c

@@ -7,11 +7,11 @@
 #include "sw/device/lib/base/hardened_memory.h"
 #include "sw/device/lib/crypto/drivers/entropy.h"
 #include "sw/device/lib/crypto/drivers/hmac.h"
-#include "sw/device/lib/crypto/impl/ecc/p384.h"
 #include "sw/device/lib/crypto/impl/security_config.h"
 #include "sw/device/lib/crypto/include/datatypes.h"
 #include "sw/device/lib/crypto/include/integrity.h"
 #include "sw/device/lib/crypto/include/keyblob.h"
+#include "sw/device/lib/crypto/include/p384.h"
 
 // Module ID for status codes.
 #define MODULE_ID MAKE_MODULE_ID('p', '3', '8')

sw/device/lib/crypto/include/BUILD

@@ -39,6 +39,8 @@ cc_library(
         "kmac.h",
         "kmac_kdf.h",
         "otcrypto.h",
+        "p256.h",
+        "p384.h",
         "rsa.h",
         "sha2.h",
         "sha3.h",
@@ -50,6 +52,7 @@ cc_library(
         "//sw/device/lib/base:hardened",
         "//sw/device/lib/base:status",
         "//sw/device/lib/crypto/drivers:keymgr",
+        "//sw/device/lib/crypto/drivers:otbn",
     ],
 )
 
@@ -74,6 +77,8 @@ cc_library(
         "kmac.h",
         "kmac_kdf.h",
         "otcrypto.h",
+        "p256.h",
+        "p384.h",
         "rsa.h",
         "sha2.h",
         "sha3.h",

sw/device/lib/crypto/impl/ecc/p256.h renamed to sw/device/lib/crypto/include/p256.h

@@ -4,13 +4,13 @@
 
 #include "sw/device/lib/base/memory.h"
 #include "sw/device/lib/base/status.h"
-#include "sw/device/lib/crypto/impl/ecc/p256.h"
-#include "sw/device/lib/crypto/impl/ecc/p384.h"
 #include "sw/device/lib/crypto/include/datatypes.h"
 #include "sw/device/lib/crypto/include/ecc_p256.h"
 #include "sw/device/lib/crypto/include/ecc_p384.h"
 #include "sw/device/lib/crypto/include/integrity.h"
 #include "sw/device/lib/crypto/include/keyblob.h"
+#include "sw/device/lib/crypto/include/p256.h"
+#include "sw/device/lib/crypto/include/p384.h"
 #include "sw/device/lib/runtime/log.h"
 #include "sw/device/lib/testing/test_framework/ujson_ottf.h"
 #include "sw/device/lib/ujson/ujson.h"

sw/device/lib/crypto/impl/ecc/p384.h renamed to sw/device/lib/crypto/include/p384.h

@@ -4,7 +4,7 @@
 
 #include "sw/device/lib/crypto/drivers/entropy.h"
 #include "sw/device/lib/crypto/drivers/otbn.h"
-#include "sw/device/lib/crypto/impl/ecc/p256.h"
+#include "sw/device/lib/crypto/include/p256.h"
 #include "sw/device/lib/crypto/include/sha2.h"
 #include "sw/device/lib/runtime/log.h"
 #include "sw/device/lib/testing/test_framework/check.h"