Skip to content

[CLI] Do not prompt for Application Class name #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
virkt25 opened this issue May 1, 2018 · 10 comments
Closed
1 task

[CLI] Do not prompt for Application Class name #1297

virkt25 opened this issue May 1, 2018 · 10 comments
Labels
developer-experience Issues affecting ease of use and overall experience of LB users

Comments

@virkt25
Copy link
Contributor

virkt25 commented May 1, 2018

Description / Steps to reproduce / Feature proposal

From #1206

Why do I need to create a class?

Related Notes:

Refers to the CLI prompting for Application Class Name. No description of what that Application class refers to.


We already prompt the user for a Project name and then prompt for an Application class name.

Acceptance Criteria

  • Remove prompt for Class Name (Use the default we generate) -- this will prevent users from having to enter the it again / get confused about what the Application class name is.
    • Might be good to have a message stating the name of the class that we generated.

See Reporting Issues for more tips on writing good issues

@raymondfeng
Copy link
Contributor

I think the proposal is against our intention - we want to have reasonable defaults based on conventions for the code generation but we also want to allow users to confirm/customize.

If the concept of Application is not clear, we can add a link or make it more descriptive in the CLI.

@bajtos
Copy link
Member

bajtos commented May 2, 2018

+1 for making the CLI prompts more descriptive, so that users understand why we are asking them about application class name.

@bajtos bajtos removed their assignment May 2, 2018
@jannyHou
Copy link
Contributor

jannyHou commented May 3, 2018

I also tend to omit the customizing step of the app class name, don't feel people often have the need to rename it...we can either make the prompt message more descriptive, or remove it and add a short document says we allow the customization.

@shimks
Copy link
Contributor

shimks commented May 3, 2018

^^^ I'm for removing the prompt for the application class name as well. In my opinion, the users that do want to customize their application class name should be able to set up a flag (--applicationClassName=CustomNameApplication).

I'm ok with the short and concise description during the prompt though.

@shimks
Copy link
Contributor

shimks commented May 8, 2018

Rejecting for estimation. More feedback wanted on what to do with the issue. Follow up spike is needed to hash out what are the potential UX we want to provide.

@dhmlau dhmlau added the developer-experience Issues affecting ease of use and overall experience of LB users label May 9, 2018
@dhmlau
Copy link
Member

dhmlau commented May 9, 2018

I'd like to propose to move this out of DP3. IMHO, this is a minor issue compared to other UX issues we're having, e.g. CLI for models/datasource/relations.

@bajtos
Copy link
Member

bajtos commented May 9, 2018

I'd like to propose to move this out of DP3. IMHO, this is a minor issue compared to other UX issues we're having, e.g. CLI for models/datasource/relations.

+1, I have changed the labels accordingly.

@dhmlau
Copy link
Member

dhmlau commented Jun 25, 2018

related to #1340

@dhmlau
Copy link
Member

dhmlau commented Aug 11, 2018

@virkt25 , we now have the --yes option for the express mode.
Is this ticket good to close? thanks.

@virkt25
Copy link
Contributor Author

virkt25 commented Aug 13, 2018

Yep.

@virkt25 virkt25 closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users
Projects
None yet
Development

No branches or pull requests

8 participants