Skip to content

Test lb4 CLI on Node 10 #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
virkt25 opened this issue May 1, 2018 · 3 comments
Closed
1 task done

Test lb4 CLI on Node 10 #1296

virkt25 opened this issue May 1, 2018 · 3 comments
Milestone

Comments

@virkt25
Copy link
Contributor

virkt25 commented May 1, 2018

Description / Steps to reproduce / Feature proposal

From #1206

Node 9 CLI issues after global install

Related Note:

Had Node installed via brew and lb4 install location wasn't part of the PATH.


User had reported error with CLI on Node version 9. Seeing as Node 10 is out and we made some changes with regards to enabling Node 10 I think the issue might've been resolved.

Acceptance Criteria

  • Test lb4 app with the latest version to make sure it works as expected
    • If there is an error -- If a simple 5 minute fix create a PR else open a new issue with the error message.

See Reporting Issues for more tips on writing good issues

@virkt25 virkt25 added the DP3 label May 1, 2018
@virkt25 virkt25 added this to the May Milestone milestone May 1, 2018
@virkt25 virkt25 removed this from the May Milestone milestone May 1, 2018
@dhmlau
Copy link
Member

dhmlau commented May 4, 2018

I've done the following:

  • installed Node v10.0.0
  • installed @loopback/cli
  • run lb4 app
  • after the app is created, run npm start
    Things seem to be working. I call the ping endpoint localhost:3000/ping, and it returned something.

@dhmlau
Copy link
Member

dhmlau commented May 4, 2018

@virkt25 , now that we know a simple app works in Node 10. It seems to meet the acceptance criteria?

@virkt25
Copy link
Contributor Author

virkt25 commented May 7, 2018

Closing as done.

@virkt25 virkt25 closed this as completed May 7, 2018
@shimks shimks added this to the May Milestone milestone May 7, 2018
@bajtos bajtos added the p1 label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants