Skip to content

Commit 3b72ced

Browse files
committed
fixup! address code review comments
1 parent 50cfbcc commit 3b72ced

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

docs/CONTRIBUTING.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Contributing to LoopBack
22

3-
Contributions to Node.js include code, documentation, answering user questions, and advocating for all types of Node.js users. See our official documentation on loopback.io for more information common to all of our GitHub repositories:
3+
Contributions to LoopBack include code, documentation, answering user questions, and advocating for all types of LoopBack users. See our official documentation on loopback.io for more information common to all of our GitHub repositories:
44

55
- http://loopback.io/doc/en/contrib/index.html
66

@@ -17,16 +17,15 @@ Issues in [strongloop/loopback-next](https://github.com/strongloop/loopback-next
1717

1818
## [Contributing code](http://loopback.io/doc/en/contrib/code-contrib.html)
1919

20-
Pull Requests are the way concrete changes are made to the code, documentation
21-
and tools contained in LoopBack repositories.
20+
Pull Requests are the way concrete changes are made to the code, documentation and tools contained in LoopBack repositories.
2221

2322
- [Setting up development environment](./DEVELOPING.md#setting-up-development-environment)
2423
- [How to contribute the code](http://loopback.io/doc/en/contrib/code-contrib.html#how-to-contribute-to-the-code)
2524
- [Building the project](./DEVELOPING.md#building-the-project)
2625
- [Running tests](./DEVELOPING.md#running-tests)
2726
- [Coding rules](./DEVELOPING.md#coding-rules)
2827
- [API documentation](./DEVELOPING.md#api-documentation)
29-
- [Git commit messages](./DEVELOPING.md#commit-message-guidelines)
28+
- [Git commit messages](./DEVELOPING.md#commit-message-guidelines) (Note that other repositories like [strongloop/loopback.io](https://github.com/strongloop/loopback.io) use a different [convention](https://loopback.io/doc/en/contrib/git-commit-messages.html).)
3029
- [Reviewing pull requests](http://loopback.io/doc/en/contrib/triaging-pull-requests.html)
3130
- [Contributor License Agreement (CLA)](http://loopback.io/doc/en/contrib/code-contrib.html#agreeing-to-the-cla)
3231

docs/DEVELOPING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ You may want to configure your IDE or editor to get better support for
2222
TypeScript too.
2323

2424
- [VisualStudio Code](./VSCODE.md)
25-
- _Missing your favorite IDE/editor here? Pull requests are welcome!_
25+
- _Missing your favorite IDE/editor here? We would love to have documentation for more IDEs/editors! Please send a pull request to add recommended setup for your tool._
2626

2727
Before getting started, it is recommended to configure `git` so that it knows who you are:
2828

@@ -119,7 +119,7 @@ The **type** must be one of the following:
119119

120120
#### scope
121121

122-
The **scope** must be a list of one or more packages contained in this monorepo. Eeach scope name must match a directory name in [packages/](../packages), e.g. `core` or `context`.
122+
The **scope** must be a list of one or more packages contained in this monorepo. Each scope name must match a directory name in [packages/](../packages), e.g. `core` or `context`.
123123

124124

125125
#### subject

0 commit comments

Comments
 (0)