chore: fix eslint violations on String instead of string

Author: raymondfeng

packages/eslint-config/eslintrc.js

@@ -60,7 +60,6 @@ module.exports = {
      */
     '@typescript-eslint/array-type': 'off',
     '@typescript-eslint/indent': 'off',
-    // '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-member-accessibility': 'off',
@@ -71,7 +70,6 @@ module.exports = {
     '@typescript-eslint/no-angle-bracket-type-assertion': 'off',
     '@typescript-eslint/prefer-interface': 'off',
     '@typescript-eslint/no-namespace': 'off',
-    // '@typescript-eslint/no-unused-vars': 'off',
     '@typescript-eslint/ban-types': 'off',
     '@typescript-eslint/no-triple-slash-reference': 'off',
     '@typescript-eslint/no-empty-interface': 'off',

packages/repository/src/__tests__/acceptance/repository.acceptance.ts

@@ -69,13 +69,13 @@ describe('Repository in Thinking in LoopBack', () => {
     @model()
     class Role extends Entity {
       @property()
-      name: String;
+      name: string;
     }
 
     @model()
     class Address extends Entity {
       @property()
-      street: String;
+      street: string;
     }
 
     @model()
@@ -87,7 +87,7 @@ describe('Repository in Thinking in LoopBack', () => {
       id: number;
 
       @property({type: 'string'})
-      name: String;
+      name: string;
 
       @property.array(Role)
       roles: Role[];

packages/repository/src/__tests__/unit/repositories/legacy-juggler-bridge.unit.ts

@@ -126,13 +126,13 @@ describe('DefaultCrudRepository', () => {
       @model()
       class Role {
         @property()
-        name: String;
+        name: string;
       }
 
       @model()
       class Address {
         @property()
-        street: String;
+        street: string;
       }
 
       @model()
@@ -144,7 +144,7 @@ describe('DefaultCrudRepository', () => {
         id: number;
 
         @property({type: 'string'})
-        name: String;
+        name: string;
 
         @property.array(Role)
         roles: Role[];