fixup! change ctx.getValueOrPromise to return ValueOrPromise

Author: bajtos

packages/context/src/context.ts

@@ -10,6 +10,7 @@ import {ResolutionOptions, ResolutionSession} from './resolution-session';
 import {v1 as uuidv1} from 'uuid';
 
 import * as debugModule from 'debug';
+import {ValueOrPromise} from '.';
 const debug = debugModule('loopback:context');
 
 /**
@@ -408,12 +409,7 @@ export class Context {
   getValueOrPromise<T>(
     keyWithPath: string,
     optionsOrSession?: ResolutionOptions | ResolutionSession,
-  ): T | PromiseLike<T> | undefined {
-    // ^^^ Note that boundValue can be any Promise-like implementation,
-    // not necessarily the native Promise instance. As such, it may be
-    // missing newer APIs like Promise#catch() and cannot be casted
-    // directly to a Promise. Callers of this method should use
-    // Promise.resolve() to convert the result into a native Promise.
+  ): ValueOrPromise<T | undefined> {
     const {key, path} = Binding.parseKeyWithPath(keyWithPath);
 
     // backwards compatibility

packages/context/src/value-promise.ts

@@ -21,8 +21,13 @@ export type BoundValue = any;
 /**
  * Representing a value or promise. This type is used to represent results of
  * synchronous/asynchronous resolution of values.
+ *
+ * Note that we are using PromiseLike instead of native Promise to describe
+ * the asynchronous variant. This allows producers of async values to use
+ * any Promise implementation (e.g. Bluebird) instead of native Promises
+ * provided by JavaScript runtime.
  */
-export type ValueOrPromise<T> = T | Promise<T>;
+export type ValueOrPromise<T> = T | PromiseLike<T>;
 
 export type MapObject<T> = {[name: string]: T};