Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar.gz support #171

Open
arykov opened this issue Dec 20, 2021 · 4 comments
Open

tar.gz support #171

arykov opened this issue Dec 20, 2021 · 4 comments
Assignees
Labels
discussion question or suggestion

Comments

@arykov
Copy link
Contributor

arykov commented Dec 20, 2021

Would be good to add tar.gz support at least for scanning at least at the top level.

@xeraph xeraph self-assigned this Dec 20, 2021
@xeraph xeraph added the discussion question or suggestion label Dec 20, 2021
@xeraph
Copy link
Contributor

xeraph commented Dec 20, 2021

Hmm.. Someone may implement this issue. However I don't want any additional dependency. Scanner will get complicated to support nested scanning and patching.

@pinacoelho
Copy link
Contributor

Since tar.gz isn't usable by a java application, this would add complexity without identifying vulnerable applications. We should keep the focus on the directly usable formarts (JAR/EAR/WAR).

@arykov
Copy link
Contributor Author

arykov commented Dec 21, 2021

@pinacoelho, agreed on complexity(relative to zip). But disagree on value. There frequently are cases when software is distributed or backed up this way. So there is a risk of reintroduction of the problem. I assume you had the same rationale when implementing zip support and deciding not to limit "nesting" at 3 ear->war->jar

@pinacoelho
Copy link
Contributor

pinacoelho commented Dec 21, 2021

So there is a risk of reintroduction of the problem.

There's always a risk, but while going down tar.gz's would cover that, it doesn't cover off-machine backups (Veritas NetBackup, IBM TSM, etc...).
Also, backups are sacred: as a sysadmin, whatever I've put in a backup, I expect to be there when I restore (for whatever reason), and that's non-negotiable from sysadmin and audit PoVs.

I assume you had the same rationale when implementing zip support and deciding not to limit "nesting" at 3 ear->war->jar

Not my rationale, but in my opinion a valid one. EARs/WARs are archives of archives, so to find the JAR that you're running, you have to go inside.

This is Xeraph's brainchild, it would be up to him to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion question or suggestion
Projects
None yet
Development

No branches or pull requests

3 participants