Skip to content

Commit 2355a2d

Browse files
authored
feat(argus,csc): accept proxy details from global configuration (#79)
1 parent cd4fec2 commit 2355a2d

File tree

6 files changed

+24
-8
lines changed

6 files changed

+24
-8
lines changed

charts/argus/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ maintainers:
1111
1212
name: LogicMonitor
1313
name: argus
14-
version: 2.2.0-rc03
14+
version: 2.2.0-rc04
1515
home: https://logicmonitor.github.io/helm-charts-qa
1616
appVersion: v8.2.0-rc1

charts/argus/templates/_argus_config.tpl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,11 @@ alerting:
5757
{{- if .Values.debug }}
5858
{{- toYaml .Values.debug | nindent 0 }}
5959
{{- end }}
60+
{{- if .Values.proxy.url }}
61+
proxy:
62+
url: {{ .Values.proxy.url }}
63+
{{- else if .Values.global.proxy.url }}
64+
proxy:
65+
url: {{ .Values.global.proxy.url }}
66+
{{- end }}
6067
{{- end -}}

charts/argus/templates/collectorset.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ spec:
3434
{{- if .Values.collector.proxy.url }}
3535
proxy:
3636
url: {{ .Values.collector.proxy.url }}
37+
{{- else if .Values.global.proxy.url }}
38+
proxy:
39+
url: {{ .Values.global.proxy.url }}
3740
{{- end }}
3841
{{- if .Values.collector.proxy.user }}
3942
secretName: {{ include "argus.fullname" . }}-collector

charts/argus/values.schema.json

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@
543543
"examples": [
544544
""
545545
],
546-
"$comment": "ui:proxyURL"
546+
"$comment": "ui:proxyURL-ignore"
547547
},
548548
"user": {
549549
"$id": "#/properties/proxy/properties/user",
@@ -554,7 +554,7 @@
554554
"examples": [
555555
""
556556
],
557-
"$comment": "ui:proxyUser"
557+
"$comment": "ui:proxyUser-ignore"
558558
},
559559
"pass": {
560560
"$id": "#/properties/proxy/properties/pass",
@@ -565,7 +565,7 @@
565565
"examples": [
566566
""
567567
],
568-
"$comment": "ui:proxyPass"
568+
"$comment": "ui:proxyPass-ignore"
569569
}
570570
},
571571
"additionalProperties": false
@@ -2114,7 +2114,8 @@
21142114
"default": "",
21152115
"examples": [
21162116
""
2117-
]
2117+
],
2118+
"$comment": "ui:proxyURL"
21182119
},
21192120
"user": {
21202121
"$id": "#/properties/proxy/properties/user",
@@ -2124,7 +2125,8 @@
21242125
"default": "",
21252126
"examples": [
21262127
""
2127-
]
2128+
],
2129+
"$comment": "ui:proxyUser"
21282130
},
21292131
"pass": {
21302132
"$id": "#/properties/proxy/properties/pass",
@@ -2134,7 +2136,8 @@
21342136
"default": "",
21352137
"examples": [
21362138
""
2137-
]
2139+
],
2140+
"$comment": "ui:proxyPass"
21382141
}
21392142
}
21402143
},

charts/collectorset-controller/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ maintainers:
66
77
name: LogicMonitor
88
name: collectorset-controller
9-
version: 1.1.0-rc03
9+
version: 1.1.0-rc04
1010
home: https://logicmonitor.github.io/helm-charts-qa
1111
appVersion: v4.1.0-rc1

charts/collectorset-controller/templates/configmap.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ data:
1818
{{- if .Values.proxy.url }}
1919
proxy:
2020
url: {{ .Values.proxy.url }}
21+
{{ else if .Values.global.proxy.url }}
22+
proxy:
23+
url: {{ .Values.global.proxy.url }}
2124
{{- end }}
2225
ignoreSSL: {{ default false .Values.ignoreSSL }}
2326
collectorServiceAccountName: {{ include "collectorset-controller.serviceAccountName" . }}-collector

0 commit comments

Comments
 (0)