Skip to content

Commit a6e7f07

Browse files
authored
Merge pull request rust-lang#19586 from Kobzol/manylinux-instead-of-zigbuild
Use a Docker container instead of Zig for building with old(er) glibc on x64 Linux
2 parents d9b61b3 + 4b5126e commit a6e7f07

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/tools/rust-analyzer/.github/workflows/release.yaml

+9-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ jobs:
3636
code-target: win32-arm64
3737
- os: ubuntu-latest
3838
target: x86_64-unknown-linux-gnu
39-
zig_target: x86_64-unknown-linux-gnu.2.28
39+
# Use a container with glibc 2.28
40+
# Zig is not used because it doesn't work with PGO
41+
container: quay.io/pypa/manylinux_2_28_x86_64
4042
code-target: linux-x64
4143
- os: ubuntu-latest
4244
target: aarch64-unknown-linux-gnu
@@ -71,6 +73,12 @@ jobs:
7173
with:
7274
node-version: 22
7375

76+
- name: Install rustup
77+
if: ${{ matrix.container }}
78+
run: |
79+
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal
80+
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
81+
7482
- name: Install Rust toolchain
7583
run: |
7684
rustup update --no-self-update stable

0 commit comments

Comments
 (0)