Merge pull request rust-lang#19265 from Shourya742/2025-03-01-add-dangling-dyn-diagnostic

feat: Add diagnostic for dangling dyn and impl

Author: lnicola

src/tools/rust-analyzer/crates/syntax/src/validation.rs

@@ -37,6 +37,7 @@ pub(crate) fn validate(root: &SyntaxNode, errors: &mut Vec<SyntaxError>) {
                 ast::FnPtrType(it) => validate_trait_object_fn_ptr_ret_ty(it, errors),
                 ast::MacroRules(it) => validate_macro_rules(it, errors),
                 ast::LetExpr(it) => validate_let_expr(it, errors),
+                ast::ImplTraitType(it) => validate_impl_object_ty(it, errors),
                 _ => (),
             }
         }
@@ -340,17 +341,34 @@ fn validate_trait_object_fn_ptr_ret_ty(ty: ast::FnPtrType, errors: &mut Vec<Synt
 
 fn validate_trait_object_ty(ty: ast::DynTraitType) -> Option<SyntaxError> {
     let tbl = ty.type_bound_list()?;
-
-    if tbl.bounds().count() > 1 {
-        let dyn_token = ty.dyn_token()?;
-        let potential_parenthesis =
-            algo::skip_trivia_token(dyn_token.prev_token()?, Direction::Prev)?;
-        let kind = potential_parenthesis.kind();
-        if !matches!(kind, T!['('] | T![<] | T![=]) {
-            return Some(SyntaxError::new("ambiguous `+` in a type", ty.syntax().text_range()));
+    let bounds_count = tbl.bounds().count();
+
+    match bounds_count {
+        0 => Some(SyntaxError::new(
+            "At least one trait is required for an object type",
+            ty.syntax().text_range(),
+        )),
+        _ if bounds_count > 1 => {
+            let dyn_token = ty.dyn_token()?;
+            let preceding_token =
+                algo::skip_trivia_token(dyn_token.prev_token()?, Direction::Prev)?;
+
+            if !matches!(preceding_token.kind(), T!['('] | T![<] | T![=]) {
+                return Some(SyntaxError::new("ambiguous `+` in a type", ty.syntax().text_range()));
+            }
+            None
         }
+        _ => None,
+    }
+}
+
+fn validate_impl_object_ty(ty: ast::ImplTraitType, errors: &mut Vec<SyntaxError>) {
+    if ty.type_bound_list().map_or(0, |tbl| tbl.bounds().count()) == 0 {
+        errors.push(SyntaxError::new(
+            "At least one trait must be specified",
+            ty.syntax().text_range(),
+        ));
     }
-    None
 }
 
 fn validate_macro_rules(mac: ast::MacroRules, errors: &mut Vec<SyntaxError>) {

src/tools/rust-analyzer/crates/syntax/test_data/parser/validation/0224_dangling_dyn.rast

@@ -0,0 +1,25 @@
+[email protected]
+  [email protected]
+    [email protected] "fn"
+    [email protected] " "
+    [email protected]
+      [email protected] "f"
+    [email protected]
+      [email protected] "("
+      [email protected]
+        [email protected]
+          [email protected] "_"
+        [email protected] ":"
+        [email protected] " "
+        [email protected]
+          [email protected] "&"
+          [email protected]
+            [email protected] "dyn"
+            [email protected]
+      [email protected] ")"
+    [email protected] " "
+    [email protected]
+      [email protected]
+        [email protected] "{"
+        [email protected] "}"
+error 9..12: At least one trait is required for an object type

src/tools/rust-analyzer/crates/syntax/test_data/parser/validation/0224_dangling_dyn.rs

@@ -0,0 +1 @@
+fn f(_: &dyn) {}

src/tools/rust-analyzer/crates/syntax/test_data/parser/validation/dangling_impl.rast

@@ -0,0 +1,23 @@
+[email protected]
+  [email protected]
+    [email protected] "fn"
+    [email protected] " "
+    [email protected]
+      [email protected] "f"
+    [email protected]
+      [email protected] "("
+      [email protected]
+        [email protected]
+          [email protected] "_"
+        [email protected] ":"
+        [email protected] " "
+        [email protected]
+          [email protected] "impl"
+          [email protected]
+      [email protected] ")"
+    [email protected] " "
+    [email protected]
+      [email protected]
+        [email protected] "{"
+        [email protected] "}"
+error 8..12: At least one trait must be specified

src/tools/rust-analyzer/crates/syntax/test_data/parser/validation/dangling_impl.rs

@@ -0,0 +1 @@
+fn f(_: impl) {}

src/tools/rust-analyzer/crates/syntax/test_data/parser/validation/dangling_impl_reference.rast

@@ -0,0 +1,25 @@
+[email protected]
+  [email protected]
+    [email protected] "fn"
+    [email protected] " "
+    [email protected]
+      [email protected] "f"
+    [email protected]
+      [email protected] "("
+      [email protected]
+        [email protected]
+          [email protected] "_"
+        [email protected] ":"
+        [email protected] " "
+        [email protected]
+          [email protected] "&"
+          [email protected]
+            [email protected] "impl"
+            [email protected]
+      [email protected] ")"
+    [email protected] " "
+    [email protected]
+      [email protected]
+        [email protected] "{"
+        [email protected] "}"
+error 9..13: At least one trait must be specified

src/tools/rust-analyzer/crates/syntax/test_data/parser/validation/dangling_impl_reference.rs

@@ -0,0 +1 @@
+fn f(_: &impl) {}