[IR] Add a test for f128 libm libcall lowering (NFC)
#148308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
f128-math-lowering-test
branch
from
4e92f6d to
b81e4dc
Compare
tgross35
force-pushed
the
f128-math-lowering-test
branch
from
b81e4dc to
4fc2b26
Compare
`f128` intrinsic functions from libm sometimes lower to `long double` library calls when they instead need to be `f128` versions. Add a generic test demonstrating current behavior.
tgross35
force-pushed
the
f128-math-lowering-test
branch
from
4fc2b26 to
7e51c6b
Compare
|
@nikic would you mind also reviewing this or requesting somebody reasonable? |
nikic
reviewed
Jul 13, 2025
| ; f128 long double. They should be passing with CHECK-F128 rather than | ||
| ; CHECK-USELD. | ||
|
|
||
| ; RUN: %if aarch64-registered-target %{ llc < %s -mtriple=aarch64-unknown-linux-gnu -verify-machineinstrs | FileCheck %s --check-prefixes=CHECK-ALL,CHECK-USELD %} |
There was a problem hiding this comment.
Please drop -verify-machineinstrs everywhere.
There was a problem hiding this comment.
Updated. What does this actually do? Many tests seem to use it, which is where I got it from
There was a problem hiding this comment.
It forces expensive verification outside EXPENSIVE_CHECKS builds. Should not be enabled unless you are specifically fixing an issue that triggers machine verifier errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f128intrinsic functions from libm sometimes lower tolong doublelibrary calls when they instead need to bef128versions. Add a generic test demonstrating current behavior.