llvm/test/MC/AArch64/seh-* tests fail when VK_COFF_IMGREL32 changes value

[MaskRay]

The enumerator VK_WEAKREF is no longer used. However, when I try removing it,

--- i/llvm/include/llvm/MC/MCExpr.h
+++ w/llvm/include/llvm/MC/MCExpr.h
@@ -199,7 +199,6 @@ public:
     VK_None,

     VK_SECREL,
-    VK_WEAKREF, // The link between the symbols in .weakref foo, bar

     VK_COFF_IMGREL32, // symbol@imgrel (image-relative)

I get failures related to AArch64 Win64EH. Perhaps something is sensitive to the value of VK_COFF_IMGREL32?

Failed Tests (4):
  LLVM :: MC/AArch64/seh-large-func-multi-epilog.s
  LLVM :: MC/AArch64/seh-large-func.s
  LLVM :: MC/AArch64/seh-packed-epilog.s
  LLVM :: MC/AArch64/seh-packed-unwind.s

@mstorsjo

[mstorsjo]

Sorry, I haven't had time to look at this yet. CC @efriedma-quic who also is quite familiar with this code.