Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f9b69a3

Browse files
committedAug 6, 2024·
Revert "[CMake] Fold export_executable_symbols_* into function args. (#101741)"
This reverts commit 5c56b46. This break lld build when using GENERATE_DRIVER.
1 parent a0fa9a3 commit f9b69a3

File tree

56 files changed

+123
-68
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+123
-68
lines changed
 

‎clang-tools-extra/clang-tidy/tool/CMakeLists.txt‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ clang_target_link_libraries(clangTidyMain
3333
# Support plugins.
3434
if(CLANG_PLUGIN_SUPPORT)
3535
set(support_plugins SUPPORT_PLUGINS)
36-
set(export_symbols EXPORT_SYMBOLS_FOR_PLUGINS)
3736
endif()
3837

3938
add_clang_tool(clang-tidy
@@ -42,7 +41,6 @@ add_clang_tool(clang-tidy
4241
DEPENDS
4342
clang-resource-headers
4443
${support_plugins}
45-
${export_symbols}
4644
)
4745
clang_target_link_libraries(clang-tidy
4846
PRIVATE
@@ -59,6 +57,10 @@ target_link_libraries(clang-tidy
5957
${ALL_CLANG_TIDY_CHECKS}
6058
)
6159

60+
if(CLANG_PLUGIN_SUPPORT)
61+
export_executable_symbols_for_plugins(clang-tidy)
62+
endif()
63+
6264
install(PROGRAMS clang-tidy-diff.py
6365
DESTINATION "${CMAKE_INSTALL_DATADIR}/clang"
6466
COMPONENT clang-tidy)

‎clang/tools/clang-linker-wrapper/CMakeLists.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ add_clang_tool(clang-linker-wrapper
3131

3232
DEPENDS
3333
${tablegen_deps}
34-
EXPORT_SYMBOLS_FOR_PLUGINS
3534
)
3635

3736
set(CLANG_LINKER_WRAPPER_LIB_DEPS
@@ -42,3 +41,5 @@ target_link_libraries(clang-linker-wrapper
4241
PRIVATE
4342
${CLANG_LINKER_WRAPPER_LIB_DEPS}
4443
)
44+
45+
export_executable_symbols_for_plugins(clang-linker-wrapper)

0 commit comments

Comments
 (0)
Please sign in to comment.