Small fixes

Author: RossBrunton

offload/liboffload/src/OffloadImpl.cpp

@@ -228,7 +228,7 @@ Error olGetDeviceInfoImplDetail(ol_device_handle_t Device,
   ReturnHelper ReturnValue(PropSize, PropValue, PropSizeRet);
 
   // Find the info if it exists under any of the given names
-  auto FindInfo = [&](InfoQueueTy &DevInfo, std::vector<std::string> &Names)
+  auto FindInfo = [&](InfoQueueTy &DevInfo, llvm::SmallVector<StringRef> &Names)
       -> std::optional<decltype(DevInfo.getQueue().begin())> {
     if (!Device->Device)
       return std::nullopt;
@@ -250,7 +250,7 @@ Error olGetDeviceInfoImplDetail(ol_device_handle_t Device,
 
     return std::nullopt;
   };
-  auto GetInfoString = [&](std::vector<std::string> Names) {
+  auto GetInfoString = [&](llvm::SmallVector<StringRef> Names) {
     InfoQueueTy DevInfo;
 
     if (auto Item = FindInfo(DevInfo, Names)) {
@@ -259,7 +259,7 @@ Error olGetDeviceInfoImplDetail(ol_device_handle_t Device,
       return "";
     }
   };
-  auto GetInfoXyz = [&](std::vector<std::string> Names) {
+  auto GetInfoXyz = [&](llvm::SmallVector<StringRef> Names) {
     InfoQueueTy DevInfo;
 
     if (auto Item = FindInfo(DevInfo, Names)) {

offload/unittests/OffloadAPI/device/olGetDeviceInfo.cpp

@@ -81,9 +81,9 @@ TEST_P(olGetDeviceInfoTest, SuccessMaxWorkGroupSize) {
   ol_dimensions_t Value{0, 0, 0};
   ASSERT_SUCCESS(olGetDeviceInfo(Device, OL_DEVICE_INFO_MAX_WORK_GROUP_SIZE,
                                  sizeof(Value), &Value));
-  ASSERT_GT(Value.x, 0);
-  ASSERT_GT(Value.y, 0);
-  ASSERT_GT(Value.z, 0);
+  ASSERT_GT(Value.x, 0u);
+  ASSERT_GT(Value.y, 0u);
+  ASSERT_GT(Value.z, 0u);
 }
 
 TEST_P(olGetDeviceInfoTest, InvalidNullHandleDevice) {