Skip to content

Commit 6f6fbba

Browse files
committed
Update the comment
1 parent dfa0b1a commit 6f6fbba

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

bolt/lib/Passes/PAuthGadgetScanner.cpp

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1320,8 +1320,15 @@ shouldReportReturnGadget(const BinaryContext &BC, const MCInstReference &Inst,
13201320
}
13211321

13221322
/// While BOLT already marks some of the branch instructions as tail calls,
1323-
/// this function tries to improve the coverage by including less obvious cases
1324-
/// when it is possible to do without introducing too many false positives.
1323+
/// this function tries to detect less obvious cases, assuming false positives
1324+
/// are acceptable as long as there are not too many of them.
1325+
///
1326+
/// It is possible that not all the instructions classified as tail calls by
1327+
/// this function are safe to be considered as such for the purpose of code
1328+
/// transformations performed by BOLT. The intention of this function is to
1329+
/// spot some of actually missed tail calls (and likely a number of unrelated
1330+
/// indirect branch instructions) as long as this doesn't increase the amount
1331+
/// of false positive reports unacceptably.
13251332
static bool shouldAnalyzeTailCallInst(const BinaryContext &BC,
13261333
const BinaryFunction &BF,
13271334
const MCInstReference &Inst) {

0 commit comments

Comments
 (0)