Reduce map lookup of section symbols

arjunUpatel · arjunUpatel · commit 47d964e21433 · 2025-06-10T00:11:01.000-04:00
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -2402,8 +2402,9 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj,
                       break;
                     TargetSecAddr = It->first;
                   }
-                  TargetSectionSymbols.push_back(&AllSymbols[It->second]);
-                  if (!AllSymbols[It->second].empty())
+                  auto *SectionSymbols = &AllSymbols[It->second];
+                  TargetSectionSymbols.push_back(SectionSymbols);
+                  if (!SectionSymbols->empty())
                     FoundSymbols = true;
                 }
               } else {

Original file line number	Diff line number	Diff line change
`@@ -2402,8 +2402,9 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj,`
`2402`	`2402`	`break;`
`2403`	`2403`	`TargetSecAddr = It->first;`
`2404`	`2404`	`}`
`2405`		`- TargetSectionSymbols.push_back(&AllSymbols[It->second]);`
`2406`		`- if (!AllSymbols[It->second].empty())`
	`2405`	`+ auto *SectionSymbols = &AllSymbols[It->second];`
	`2406`	`+ TargetSectionSymbols.push_back(SectionSymbols);`
	`2407`	`+ if (!SectionSymbols->empty())`
`2407`	`2408`	`FoundSymbols = true;`
`2408`	`2409`	`}`
`2409`	`2410`	`} else {`